Source/web/WebViewImpl.cpp - Issue 319633007: Move WebScreenOrientationClient to WebFrameClient.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebViewImpl.cpp

Issue 319633007: Move WebScreenOrientationClient to WebFrameClient. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: m_client null check Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebViewImpl.cpp

diff --git a/Source/web/WebViewImpl.cpp b/Source/web/WebViewImpl.cpp

index 51c45460b378c2f15239fceba6f3b17969307127..08a1560797fbc815c6b422245aefe1e49c5d7e76 100644

--- a/Source/web/WebViewImpl.cpp

+++ b/Source/web/WebViewImpl.cpp

@@ -84,7 +84,6 @@

#include "modules/encryptedmedia/MediaKeysController.h"

#include "modules/indexeddb/InspectorIndexedDBAgent.h"

#include "modules/push_messaging/PushController.h"

-#include "modules/screen_orientation/ScreenOrientationController.h"

#include "platform/ContextMenu.h"

#include "platform/ContextMenuItem.h"

#include "platform/Cursor.h"

@@ -428,8 +427,6 @@ WebViewImpl::WebViewImpl(WebViewClient* client)

providePushControllerTo(*m_page, m_client->webPushClient());

setDeviceScaleFactor(m_client->screenInfo().deviceScaleFactor);

setVisibilityState(m_client->visibilityState(), true);

- if (RuntimeEnabledFeatures::screenOrientationEnabled())

- ScreenOrientationController::provideTo(*m_page, m_client->webScreenOrientationClient());

}

m_inspectorSettingsMap = adoptPtr(new SettingsMap);

« no previous file with comments | « Source/web/WebLocalFrameImpl.cpp ('k') | public/platform/WebScreenOrientationClient.h » ('j') | no next file with comments »