Source/web/WebLocalFrameImpl.cpp - Issue 319633007: Move WebScreenOrientationClient to WebFrameClient.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebLocalFrameImpl.cpp

Issue 319633007: Move WebScreenOrientationClient to WebFrameClient. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: m_client null check Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebLocalFrameImpl.cpp

diff --git a/Source/web/WebLocalFrameImpl.cpp b/Source/web/WebLocalFrameImpl.cpp

index 48a17adfc6bd43d1d37e162fd1a13fd2304a2e08..4c8425412945a28cc51831a6b0120d878f8c0384 100644

--- a/Source/web/WebLocalFrameImpl.cpp

+++ b/Source/web/WebLocalFrameImpl.cpp

@@ -135,6 +135,7 @@

#include "core/timing/Performance.h"

#include "modules/geolocation/GeolocationController.h"

#include "modules/notifications/NotificationController.h"

+#include "modules/screen_orientation/ScreenOrientationController.h"

#include "platform/TraceEvent.h"

#include "platform/UserGestureIndicator.h"

#include "platform/clipboard/ClipboardUtilities.h"

@@ -1620,6 +1621,8 @@ void WebLocalFrameImpl::setWebCoreFrame(PassRefPtr<WebCore::LocalFrame> frame)

provideGeolocationTo(*m_frame, m_geolocationClientProxy.get());

m_geolocationClientProxy->setController(GeolocationController::from(m_frame.get()));

provideMIDITo(*m_frame, MIDIClientProxy::create(m_client ? m_client->webMIDIClient() : 0));

+ if (RuntimeEnabledFeatures::screenOrientationEnabled())

+ ScreenOrientationController::provideTo(*m_frame, m_client ? m_client->webScreenOrientationClient() : 0);

}

« no previous file with comments | « Source/modules/screen_orientation/ScreenOrientationController.cpp ('k') | Source/web/WebViewImpl.cpp » ('j') | no next file with comments »