Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Unified Diff: net/socket/stream_listen_socket.h

Issue 319593013: Added unit test for DevTools' ephemeral port support. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed review feedback from jar. Made GetLocalAddressImpl protected. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/stream_listen_socket.h
diff --git a/net/socket/stream_listen_socket.h b/net/socket/stream_listen_socket.h
index 90b54500ace17f2f28631f3fa8449e644564f298..0757520f4049224b34b563e2f4449e28b5bea674 100644
--- a/net/socket/stream_listen_socket.h
+++ b/net/socket/stream_listen_socket.h
@@ -100,6 +100,9 @@ class NET_EXPORT StreamListenSocket
void WatchSocket(WaitState state);
void UnwatchSocket();
+ // For testing use only!
+ virtual int GetLocalAddressImpl(IPEndPoint* address);
wtc 2014/06/10 17:46:44 Nit: please document how GetLocalAddressImpl diffe
wtc 2014/06/10 17:48:28 Just to clarify: if you keep GetLocalAddressImpl,
Ken Russell (switch to Gerrit) 2014/06/10 18:57:07 Thanks for the suggestion. That's fine with me, an
+
Delegate* const socket_delegate_;
private:

Powered by Google App Engine
This is Rietveld 408576698