Added unit test for DevTools' ephemeral port support.

net/socket/stream_listen_socket.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Stream-based listen socket implementation that handles reading and writing
 // to the socket, but does not handle creating the socket nor connecting
 // sockets, which are handled by subclasses on creation and in Accept,
 // respectively.
 
 // StreamListenSocket handles IO asynchronously in the specified MessageLoop.
@@ skipping 82 matching lines @@
   void Listen();
   void Read();
   void Close();
   void CloseSocket();
 
   // Pass any value in case of Windows, because in Windows
   // we are not using state.
   void WatchSocket(WaitState state);
   void UnwatchSocket();
 
+  // For testing use only!
+  virtual int GetLocalAddressImpl(IPEndPoint* address);

[wtc, 2014/06/10 17:46:44]

Nit: please document how GetLocalAddressImpl differs from GetLocalAddress. They
have exactly the same prototype.

Update: after reading the entire CL, I now understand how you intend
GetLocalAddressImpl to be used. Why don't you just declare GetPeerAddress as a
virtual method?

[wtc, 2014/06/10 17:48:28]

Just to clarify: if you keep GetLocalAddressImpl, please document how it is
intended to be used, because the only way for a reader to figure that out now is
to read content/browser/devtools/devtools_http_handler_unittest.cc, which is
outside the net/ directory.

[Ken Russell (switch to Gerrit), 2014/06/10 18:57:07]

Thanks for the suggestion. That's fine with me, and simpler. Made both
GetLocalAddress and GetPeerAddress virtual, and documented them as virtual for
unit test purposes.

+
   Delegate* const socket_delegate_;
 
  private:
   friend class TransportClientSocketTest;
 
   void SendInternal(const char* bytes, int len);
 
 #if defined(OS_WIN)
   // ObjectWatcher delegate.
   virtual void OnObjectSignaled(HANDLE object);
@@ skipping 28 matching lines @@
   virtual ~StreamListenSocketFactory() {}
 
   // Returns a new instance of StreamListenSocket or NULL if an error occurred.
   virtual scoped_ptr<StreamListenSocket> CreateAndListen(
       StreamListenSocket::Delegate* delegate) const = 0;
 };
 
 }  // namespace net
 
 #endif  // NET_SOCKET_STREAM_LISTEN_SOCKET_H_