Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6561)

Unified Diff: chrome/renderer/chrome_content_renderer_client.cc

Issue 319553008: Updated Plugin bubble model to add "learn more" link and to appear with a sliding yellow thing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changed the comment line Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/chrome_content_renderer_client.cc
diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc
index f57f12bf502f9d4f60982d07c5da09d6f98abe9c..7262d0811af254799feca0db3b472af75eeedcdf 100644
--- a/chrome/renderer/chrome_content_renderer_client.cc
+++ b/chrome/renderer/chrome_content_renderer_client.cc
@@ -796,10 +796,13 @@ WebPlugin* ChromeContentRendererClient::CreatePlugin(
IDR_BLOCKED_PLUGIN_HTML,
l10n_util::GetStringFUTF16(IDS_PLUGIN_NOT_AUTHORIZED, group_name));
placeholder->set_allow_loading(true);
+ // Send IPC for showing infobar.
render_frame->Send(new ChromeViewHostMsg_BlockedUnauthorizedPlugin(
render_frame->GetRoutingID(),
group_name,
identifier));
+ // Send IPC for showing content_setting_image/bubble.
+ observer->DidBlockContentType(content_type);
sky 2014/06/12 20:00:33 Why isn't ChromeViewHostMsg_BlockedUnauthorizedPlu
radhikabhar 2014/06/12 20:37:19 In the new UI the infobar will be placed behind a
sky 2014/06/12 22:56:31 I don't understand why that means a new message ne
radhikabhar 2014/06/12 23:41:33 One question - Are you thinking about adding this
break;
}
case ChromeViewHostMsg_GetPluginInfo_Status::kClickToPlay: {

Powered by Google App Engine
This is Rietveld 408576698