Updated Plugin bubble model to add "learn more" link and to appear with a sliding yellow thing

chrome/renderer/chrome_content_renderer_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/chrome_content_renderer_client.h"
 
 #include "base/command_line.h"
 #include "base/debug/crash_logging.h"
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
@@ skipping 778 matching lines @@
         placeholder = ChromePluginPlaceholder::CreateBlockedPlugin(
             render_frame,
             frame,
             params,
             plugin,
             identifier,
             group_name,
             IDR_BLOCKED_PLUGIN_HTML,
             l10n_util::GetStringFUTF16(IDS_PLUGIN_NOT_AUTHORIZED, group_name));
         placeholder->set_allow_loading(true);
+        // Send IPC for showing infobar.
         render_frame->Send(new ChromeViewHostMsg_BlockedUnauthorizedPlugin(
             render_frame->GetRoutingID(),
             group_name,
             identifier));
+        // Send IPC for showing content_setting_image/bubble.
+        observer->DidBlockContentType(content_type);

[sky, 2014/06/12 20:00:33]

Why isn't ChromeViewHostMsg_BlockedUnauthorizedPlugin enough?

[radhikabhar, 2014/06/12 20:37:19]

In the new UI the infobar will be placed behind a finch trial and only the
bubble model will be visible. It is linked to this change -
https://codereview.chromium.org/300873002/

[sky, 2014/06/12 22:56:31]

I don't understand why that means a new message needs to be sent. Shouldn't the
decision as to what UI to be shown not depend upon what message is sent? Said
differently, why isn't ChromeViewHostMsg_BlockedUnauthorizedPlugin enough?

[radhikabhar, 2014/06/12 23:41:33]

One question - Are you thinking about adding this exception to change the status
of the Unauthorized Plugins for NPAPI to Blocked above the switch statement in
line 608 or why two IPC are being sent here?

Also, I am actually not implementing the part of the plugin being displayed
behind a Finch trial (that is being implemented in 
https://codereview.chromium.org/300873002) so should I just delete the IPC for
showing the bubble model and revert it back to the original state and let the
other CL handle this?
 

         break;
       }
       case ChromeViewHostMsg_GetPluginInfo_Status::kClickToPlay: {
         placeholder = ChromePluginPlaceholder::CreateBlockedPlugin(
             render_frame,
             frame,
             params,
             plugin,
             identifier,
             group_name,
@@ skipping 630 matching lines @@
   CommandLine* command_line = CommandLine::ForCurrentProcess();
   return !command_line->HasSwitch(extensions::switches::kExtensionProcess);
 }
 
 blink::WebWorkerPermissionClientProxy*
 ChromeContentRendererClient::CreateWorkerPermissionClientProxy(
     content::RenderFrame* render_frame,
     blink::WebFrame* frame) {
   return new WorkerPermissionClientProxy(render_frame, frame);
 }