Updated Plugin bubble model to add "learn more" link and to appear with a sliding yellow thing

chrome/browser/content_settings/tab_specific_content_settings.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CONTENT_SETTINGS_TAB_SPECIFIC_CONTENT_SETTINGS_H_
 #define CHROME_BROWSER_CONTENT_SETTINGS_TAB_SPECIFIC_CONTENT_SETTINGS_H_
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 240 matching lines @@
   // Set whether the setting for the pending handler is DEFAULT (ignore),
   // ALLOW, or DENY.
   void set_pending_protocol_handler_setting(ContentSetting setting) {
     pending_protocol_handler_setting_ = setting;
   }
 
   ContentSetting pending_protocol_handler_setting() const {
     return pending_protocol_handler_setting_;
   }
 
+  //Set whether the setting for the plugin bubble mode is Allow, Block or Run

[felt, 2014/06/11 02:37:29]

You need a space and a period at the end of the sentence, like: 

// Set whether ...
// this time.

[radhikabhar, 2014/06/11 17:31:46]

Done.

+  //this time
+  void set_plugin_bubble_setting(ContentSetting setting) {
+    plugin_bubble_setting_ = setting;
+  }
+
+  ContentSetting plugin_bubble_setting() const {
+    return plugin_bubble_setting_;
+  }
 
   // Returns a pointer to the |LocalSharedObjectsContainer| that contains all
   // allowed local shared objects like cookies, local storage, ... .
   const LocalSharedObjectsContainer& allowed_local_shared_objects() const {
     return allowed_local_shared_objects_;
   }
 
   // Returns a pointer to the |LocalSharedObjectsContainer| that contains all
   // blocked local shared objects like cookies, local storage, ... .
   const LocalSharedObjectsContainer& blocked_local_shared_objects() const {
     return blocked_local_shared_objects_;
   }
 
+  // TODO(radhikabhar): This is no longer needed as we have deleted the custom

[felt, 2014/06/11 02:37:29]

Why is this a TODO? Why aren't you doing it right here?

[radhikabhar, 2014/06/11 17:31:46]

Removed it

+  // link in the plugin bubble model
   bool load_plugins_link_enabled() { return load_plugins_link_enabled_; }
   void set_load_plugins_link_enabled(bool enabled) {
     load_plugins_link_enabled_ = enabled;
   }
 
   // Called to indicate whether access to the Pepper broker was allowed or
   // blocked.
   void SetPepperBrokerAllowed(bool allowed);
 
   // content::WebContentsObserver overrides.
@@ skipping 114 matching lines @@
 
   // The previous protocol handler to be replaced by
   // the pending_protocol_handler_, if there is one. Empty if
   // there is no handler which would be replaced.
   ProtocolHandler previous_protocol_handler_;
 
   // The setting on the pending protocol handler registration. Persisted in case
   // the user opens the bubble and makes changes multiple times.
   ContentSetting pending_protocol_handler_setting_;
 
+  // The setting on the plugin bubble model. Persisted in case
+  // the user opens the bubble and makes changes multiple times.
+  ContentSetting plugin_bubble_setting_;
+
+  // TODO(radhikabhar): This is no longer needed as we have got rid of the
+  // custom link

[felt, 2014/06/11 02:37:29]

Same question, why is this a TODO?

[radhikabhar, 2014/06/11 17:31:46]

Done.

   // Stores whether the user can load blocked plugins on this page.
   bool load_plugins_link_enabled_;
 
   content::NotificationRegistrar registrar_;
 
   // The origin of the media stream request. Note that we only support handling
   // settings for one request per tab. The latest request's origin will be
   // stored here. http://crbug.com/259794
   GURL media_stream_access_origin_;
 
   // The devices to be displayed in the media bubble when the media stream
   // request is requesting certain specific devices.
   std::string media_stream_requested_audio_device_;
   std::string media_stream_requested_video_device_;
 
   DISALLOW_COPY_AND_ASSIGN(TabSpecificContentSettings);
 };
 
 #endif  // CHROME_BROWSER_CONTENT_SETTINGS_TAB_SPECIFIC_CONTENT_SETTINGS_H_