Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Issue 319513006: Remove SK_IGNORE_DWRITE_BITMAP_FIX. (Closed)

Created:
6 years, 6 months ago by bungeman-skia
Modified:
6 years, 6 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Remove SK_IGNORE_DWRITE_BITMAP_FIX. This define has been removed from Blink and is no longer used anywhere. TBR=reed1 Committed: https://skia.googlesource.com/skia/+/df1640d413c16abf4527960642aca41581808699

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -16 lines) Patch
M src/ports/SkFontHost_win_dw.cpp View 3 chunks +2 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bungeman-skia
6 years, 6 months ago (2014-06-04 20:55:55 UTC) #1
bungeman-skia
Since this is effectively just a revert of https://codereview.chromium.org/309503002 , committing TBR.
6 years, 6 months ago (2014-06-04 22:09:24 UTC) #2
bungeman-skia
The CQ bit was checked by bungeman@google.com
6 years, 6 months ago (2014-06-04 22:10:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bungeman@google.com/319513006/1
6 years, 6 months ago (2014-06-04 22:10:19 UTC) #4
bungeman-skia
Just wanted to not that the DirectWrite trybot was red because of rebaselines which were ...
6 years, 6 months ago (2014-06-04 22:12:07 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 22:19:52 UTC) #6
Message was sent while issue was closed.
Change committed as df1640d413c16abf4527960642aca41581808699

Powered by Google App Engine
This is Rietveld 408576698