Issue 309503002: Put DirectWrite bitmap fix behind the SK_IGNORE_DWRITE_BITMAP_FIX flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 309503002: Put DirectWrite bitmap fix behind the SK_IGNORE_DWRITE_BITMAP_FIX flag. (Closed)

Created:
6 years, 6 months ago by bungeman-chromium

Modified:
6 years, 6 months ago

Reviewers:
bungeman-skia, epoger, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Put DirectWrite bitmap fix behind the SK_IGNORE_DWRITE_BITMAP_FIX flag. R=reed@google.com Committed: https://code.google.com/p/skia/source/detail?r=14956

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -2 lines)			Patch
	M	src/ports/SkFontHost_win_dw.cpp	View		3 chunks	+16 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

bungeman-skia

At the time it wan't necessary to have this behind a flag, but now that ...

6 years, 6 months ago (2014-05-29 15:42:52 UTC) #1

bungeman-skia

The change this is updating / placing behind the flag is https://codereview.chromium.org/303773002 .

6 years, 6 months ago (2014-05-29 15:45:05 UTC) #3

bungeman-chromium

Committed patchset #1 manually as r14956 (presubmit successful).

6 years, 6 months ago (2014-05-29 15:54:43 UTC) #4

epoger

6 years, 6 months ago (2014-05-29 16:49:01 UTC) #5

Message was sent while issue was closed.

If there is a guard flag you need Chrome to pick up, I think you can add it
here:
https://skia.googlesource.com/skia/+/master/gyp/skia_for_chromium_defines.gypi

Expand Messages | Collapse Messages