Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 319503004: Fix use-after-free in geolocation layout test code introduced in r175404. (Closed)

Created:
6 years, 6 months ago by jam
Modified:
6 years, 6 months ago
Reviewers:
ojan
CC:
blink-reviews, mvanouwerkerk+watch_chromium.org, timvolodine
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Fix use-after-free in geolocation layout test code introduced in r175404. BUG=380588 TBR=ojan Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175510

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M Source/modules/geolocation/GeolocationController.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jam
6 years, 6 months ago (2014-06-04 17:37:30 UTC) #1
jam
I'm going to TBR this since it's a two-liner and the test is flaky and ...
6 years, 6 months ago (2014-06-04 19:02:45 UTC) #2
jam
The CQ bit was checked by jam@chromium.org
6 years, 6 months ago (2014-06-04 19:02:46 UTC) #3
jam
The CQ bit was checked by jam@chromium.org
6 years, 6 months ago (2014-06-04 19:02:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jam@chromium.org/319503004/1
6 years, 6 months ago (2014-06-04 19:03:11 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 19:45:45 UTC) #6
Message was sent while issue was closed.
Change committed as 175510

Powered by Google App Engine
This is Rietveld 408576698