Source/modules/geolocation/GeolocationController.cpp - Issue 319503004: Fix use-after-free in geolocation layout test code introduced in r175404.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/geolocation/GeolocationController.cpp

Issue 319503004: Fix use-after-free in geolocation layout test code introduced in r175404. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/geolocation/GeolocationController.cpp

diff --git a/Source/modules/geolocation/GeolocationController.cpp b/Source/modules/geolocation/GeolocationController.cpp

index 1c1f8bf30420eb20e4397a34610699a98003b0d0..78151301cb3b03726b92a9dda7c539d99cae668c 100644

--- a/Source/modules/geolocation/GeolocationController.cpp

+++ b/Source/modules/geolocation/GeolocationController.cpp

@@ -181,6 +181,8 @@ GeolocationPosition* GeolocationController::lastPosition()

void GeolocationController::setClientForTest(GeolocationClient* client)

{

+ if (m_hasClientForTest)

+ m_client->controllerForTestRemoved(this);

m_client = client;

m_hasClientForTest = true;

« no previous file with comments | « no previous file | no next file » | no next file with comments »