gyp_skia - Issue 319503003: On Windows, fail if there are missing files specified in the project.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gyp_skia

Issue 319503003: On Windows, fail if there are missing files specified in the project. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gyp_skia

diff --git a/gyp_skia b/gyp_skia

index 66adf08cb90b465b680533857a6acb71910d665c..d6cb946a93f7c32e1fe16cc9958c3c2551d0ce3d 100755

--- a/gyp_skia

+++ b/gyp_skia

@@ -126,6 +126,10 @@ if __name__ == '__main__':

# By default, we build 'most' instead of 'all' or 'everything'. See skia.gyp.

args.extend(['-Gdefault_target=most'])

+ # Fail if there are files specified in the project but are missing

epoger 2014/06/04 15:25:42 maybe... # Fail if any files specified in the pro

jvanverth1 2014/06/04 17:07:14 Done.

+ if sys.platform.startswith('win'):

+ os.environ['GYP_GENERATOR_FLAGS'] = 'msvs_error_on_missing_sources=1'

epoger 2014/06/04 15:25:42 Is it possible for the user to have already specif

jvanverth1 2014/06/04 17:07:14 Done.

print 'Updating projects from gyp files...'

sys.stdout.flush()

« no previous file with comments | « no previous file | no next file » | no next file with comments »