Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 319493006: [Mac] Set CFBundleDocumentTypes for PDF in the Info.plist directly. (Closed)

Created:
6 years, 6 months ago by Robert Sesek
Modified:
6 years, 6 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

[Mac] Set CFBundleDocumentTypes for PDF in the Info.plist directly. This was previously added at build-time using tweak_info_plist.py, but now that Chromium includes Pdfium, Chromium.app and Chrome.app both always support PDF. TEST=Chromium and Chrome are both registered to open PDF documents. R=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275088

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -57 lines) Patch
M build/mac/tweak_info_plist.py View 3 chunks +0 lines, -53 lines 0 comments Download
M chrome/app/app-Info.plist View 1 chunk +16 lines, -0 lines 0 comments Download
M chrome/chrome_exe.gypi View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Robert Sesek
6 years, 6 months ago (2014-06-04 22:21:44 UTC) #1
Nico
\o/ Is the PDF plugin bundled with Chromium yet? lgtm if so.
6 years, 6 months ago (2014-06-04 22:27:13 UTC) #2
Robert Sesek
On 2014/06/04 22:27:13, Nico (away) wrote: > \o/ > > Is the PDF plugin bundled ...
6 years, 6 months ago (2014-06-04 22:33:30 UTC) #3
Robert Sesek
The CQ bit was checked by rsesek@chromium.org
6 years, 6 months ago (2014-06-04 22:44:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/319493006/1
6 years, 6 months ago (2014-06-04 22:46:43 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-05 03:17:58 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-05 03:27:41 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel/builds/13634)
6 years, 6 months ago (2014-06-05 03:27:42 UTC) #8
Robert Sesek
The CQ bit was checked by rsesek@chromium.org
6 years, 6 months ago (2014-06-05 12:32:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/319493006/1
6 years, 6 months ago (2014-06-05 12:33:14 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-05 14:10:24 UTC) #11
Message was sent while issue was closed.
Change committed as 275088

Powered by Google App Engine
This is Rietveld 408576698