[Mac] Set CFBundleDocumentTypes for PDF in the Info.plist directly.

build/mac/tweak_info_plist.py

 #!/usr/bin/env python
 
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 #
 # Xcode supports build variable substitutions and CPP; sadly, that doesn't work
 # because:
 #
@@ skipping 114 matching lines @@
   # See if the operation failed.
   _RemoveKeys(plist, 'SCMRevision')
   if scm_revision != None:
     plist['SCMRevision'] = scm_revision
   elif add_keys:
     print >>sys.stderr, 'Could not determine SCM revision.  This may be OK.'
 
   return True
 
 
-def _DoPDFKeys(plist, add_keys):
-  """Adds PDF support to the document types list. If add_keys is True, it will
-  add the type information dictionary. If it is False, it will remove it if
-  present."""
-
-  PDF_FILE_EXTENSION = 'pdf'
-
-  def __AddPDFKeys(sub_plist):
-    """Writes the keys into a sub-dictionary of the plist."""
-    sub_plist['CFBundleTypeExtensions'] = [PDF_FILE_EXTENSION]
-    sub_plist['CFBundleTypeIconFile'] = 'document.icns'
-    sub_plist['CFBundleTypeMIMETypes'] = 'application/pdf'
-    sub_plist['CFBundleTypeName'] = 'PDF Document'
-    sub_plist['CFBundleTypeRole'] = 'Viewer'
-
-  DOCUMENT_TYPES_KEY = 'CFBundleDocumentTypes'
-
-  # First get the list of document types, creating it if necessary.
-  try:
-    extensions = plist[DOCUMENT_TYPES_KEY]
-  except KeyError:
-    # If this plist doesn't have a type dictionary, create one if set to add the
-    # keys. If not, bail.
-    if not add_keys:
-      return
-    extensions = plist[DOCUMENT_TYPES_KEY] = []
-
-  # Loop over each entry in the list, looking for one that handles PDF types.
-  for i, ext in enumerate(extensions):
-    # If an entry for .pdf files is found...
-    if 'CFBundleTypeExtensions' not in ext:
-      continue
-    if PDF_FILE_EXTENSION in ext['CFBundleTypeExtensions']:
-      if add_keys:
-        # Overwrite the existing keys with new ones.
-        __AddPDFKeys(ext)
-      else:
-        # Otherwise, delete the entry entirely.
-        del extensions[i]
-      return
-
-  # No PDF entry exists. If one needs to be added, do so now.
-  if add_keys:
-    pdf_entry = {}
-    __AddPDFKeys(pdf_entry)
-    extensions.append(pdf_entry)
-
-
 def _AddBreakpadKeys(plist, branding):
   """Adds the Breakpad keys. This must be called AFTER _AddVersionKeys() and
   also requires the |branding| argument."""
   plist['BreakpadReportInterval'] = '3600'  # Deliberately a string.
   plist['BreakpadProduct'] = '%s_Mac' % branding
   plist['BreakpadProductDisplay'] = branding
   plist['BreakpadVersion'] = plist['CFBundleShortVersionString']
   # These are both deliberately strings and not boolean.
   plist['BreakpadSendAndExit'] = 'YES'
   plist['BreakpadSkipConfirm'] = 'YES'
@@ skipping 59 matching lines @@
   parser = optparse.OptionParser('%prog [options]')
   parser.add_option('--breakpad', dest='use_breakpad', action='store',
       type='int', default=False, help='Enable Breakpad [1 or 0]')
   parser.add_option('--breakpad_uploads', dest='breakpad_uploads',
       action='store', type='int', default=False,
       help='Enable Breakpad\'s uploading of crash dumps [1 or 0]')
   parser.add_option('--keystone', dest='use_keystone', action='store',
       type='int', default=False, help='Enable Keystone [1 or 0]')
   parser.add_option('--scm', dest='add_scm_info', action='store', type='int',
       default=True, help='Add SCM metadata [1 or 0]')
-  parser.add_option('--pdf', dest='add_pdf_support', action='store', type='int',
-      default=False, help='Add PDF file handler support [1 or 0]')
   parser.add_option('--branding', dest='branding', action='store',
       type='string', default=None, help='The branding of the binary')
   parser.add_option('--bundle_id', dest='bundle_identifier',
       action='store', type='string', default=None,
       help='The bundle id of the binary')
   parser.add_option('--version', dest='version', action='store', type='string',
       default=None, help='The version string [major.minor.build.patch]')
   (options, args) = parser.parse_args(argv)
 
   if len(args) > 0:
@@ skipping 33 matching lines @@
       print >>sys.stderr, 'Use of Keystone requires the bundle id.'
       return 1
     _AddKeystoneKeys(plist, options.bundle_identifier)
   else:
     _RemoveKeystoneKeys(plist)
 
   # Adds or removes any SCM keys.
   if not _DoSCMKeys(plist, options.add_scm_info):
     return 3
 
-  # Adds or removes the PDF file handler entry.
-  _DoPDFKeys(plist, options.add_pdf_support)
-
   # Now that all keys have been mutated, rewrite the file.
   temp_info_plist = tempfile.NamedTemporaryFile()
   plistlib.writePlist(plist, temp_info_plist.name)
 
   # Info.plist will work perfectly well in any plist format, but traditionally
   # applications use xml1 for this, so convert it to ensure that it's valid.
   proc = subprocess.Popen(['plutil', '-convert', 'xml1', '-o', DEST_INFO_PLIST,
                            temp_info_plist.name])
   proc.wait()
   return proc.returncode
 
 
 if __name__ == '__main__':
   sys.exit(Main(sys.argv[1:]))