Issue 319453002: [oilpan]: get rid of some trivial RefPtr's to node.

Issue 319453002: [oilpan]: get rid of some trivial RefPtr's to node. (Closed)

Created:
6 years, 6 months ago by wibling-chromium

Modified:
6 years, 6 months ago

Reviewers:
Vyacheslav Egorov (Chromium), Mads Ager (chromium), tkent, zerny-chromium, Erik Corry, haraken, oilpan-reviews

CC:
blink-reviews, eustas+blink_chromium.org, caseq+blink_chromium.org, loislo+blink_chromium.org, pfeldman+blink_chromium.org, malch+blink_chromium.org, sof, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

[oilpan]: get rid of some trivial RefPtr's to node. R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, tkent@chromium.org, vegorov@chromium.org, zerny@chromium.org BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175497

Patch Set 1 #

Total comments: 2

Patch Set 2 : review feedback #

Patch Set 3 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -17 lines)			Patch
M	Source/core/dom/ContainerNode.cpp	View	1 2	10 chunks	+13 lines, -12 lines	0 comments	Download
M	Source/core/dom/Node.cpp	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/inspector/DOMPatchSupport.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

haraken

LGTM https://codereview.chromium.org/319453002/diff/1/Source/core/dom/ContainerNode.cpp File Source/core/dom/ContainerNode.cpp (right): https://codereview.chromium.org/319453002/diff/1/Source/core/dom/ContainerNode.cpp#newcode331 Source/core/dom/ContainerNode.cpp:331: RefPtrWillBeRawPtr<Node> removedChild = oldChild; Shall we rename |removeChild| ...

6 years, 6 months ago (2014-06-04 14:16:30 UTC) #2

wibling-chromium

Thanks for the review! https://codereview.chromium.org/319453002/diff/1/Source/core/dom/ContainerNode.cpp File Source/core/dom/ContainerNode.cpp (right): https://codereview.chromium.org/319453002/diff/1/Source/core/dom/ContainerNode.cpp#newcode331 Source/core/dom/ContainerNode.cpp:331: RefPtrWillBeRawPtr<Node> removedChild = oldChild; On ...

6 years, 6 months ago (2014-06-04 14:19:37 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wibling@chromium.org/319453002/40001

6 years, 6 months ago (2014-06-04 14:28:24 UTC) #5

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...

6 years, 6 months ago (2014-06-04 16:16:37 UTC) #6

Message was sent while issue was closed.

Change committed as 175497

Expand Messages | Collapse Messages