Chromium Code Reviews Chromium Code Reviews
Issue 319443003:
Clear the suggested value while setting value for <select> element. (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| Index: LayoutTests/fast/forms/suggested-value-after-setvalue.html |
| diff --git a/LayoutTests/fast/forms/suggested-value-after-setvalue.html b/LayoutTests/fast/forms/suggested-value-after-setvalue.html |
| index f271d2956128b738599d6c81ff351a5670fc6a60..86fd74519109efcdd0f129c542535a2bfab81719 100644 |
| --- a/LayoutTests/fast/forms/suggested-value-after-setvalue.html |
| +++ b/LayoutTests/fast/forms/suggested-value-after-setvalue.html |
| @@ -2,11 +2,15 @@ |
| <html> |
| <body> |
| <p id="description">This test setting a value clears suggested value.</p> |
| -<pre><input id="test" type="text" value="initial value"></pre> |
| +<pre><input id="test" type="text" value="initial value"><textarea id="textarea"></textarea><select id="select"><option>CA</option><option>TX</option></select></pre> |
|
Ilya Sherman
2014/06/05 23:49:39
Can you add linebreaks so that this is more readab
|
| <script src="../../resources/dump-as-markup.js"></script> |
| <script> |
| var input = document.getElementById('test'); |
| +var textarea = document.getElementById('textarea'); |
| +textarea.value = "initial value"; |
| +var select = document.getElementById('select'); |
| +select.selectedIndex = -1; |
| var result = document.getElementById('result'); |
| if (!window.internals) |
| testFailed('This test requires internals object'); |
| @@ -15,6 +19,8 @@ else { |
| input.selectionStart = input.selectionEnd = 0; |
| internals.setSuggestedValue(input, 'suggested value'); |
| + internals.setSuggestedValue(textarea, 'suggested value'); |
| + internals.setSuggestedValue(select, 'TX'); |
| Markup.description(document.getElementById('description').textContent) |
| @@ -30,12 +36,18 @@ else { |
| addTextResult('internals.suggestedValue(input)'); |
| addTextResult('input.selectionStart'); |
| addTextResult('input.selectionEnd'); |
| + addTextResult('textarea.value'); |
| + addTextResult('internals.suggestedValue(textarea)'); |
| + addTextResult('select.value'); |
| + addTextResult('internals.suggestedValue(select)'); |
| } |
| log(); |
| Markup.dump(input.parentNode, 'After setting suggestedValue'); |
| input.value = 'new value'; |
| + textarea.value = 'new value'; |
| + select.value = 'CA'; |
| log(); |
| var innerTextValue = internals.shadowRoot(input).firstChild.innerText; |
