Issue 319373004: Revert 275646 "Generalize printer color model handling, get rid ..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 319373004: Revert 275646 "Generalize printer color model handling, get rid ..." (Closed)

Created:
6 years, 6 months ago by Vitaly Buka (NO REVIEWS)

Modified:
6 years, 6 months ago

Reviewers:
Aleksey Shlyapnikov

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 275646 "Generalize printer color model handling, get rid ..." Speculative revert. Something breaks "Linux ASan LSan Tests", TaskManagerNewPrintPreview. > Generalize printer color model handling, get rid of CUPS specific case. Enable supported paper szes reporting for all platforms. > > BUG=239879 > > Review URL: https://codereview.chromium.org/324523002 TBR=alekseys@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275711

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+190 lines, -226 lines)			Patch
M	trunk/src/chrome/browser/resources/print_preview/data/print_ticket_store.js	View	1 chunk	+11 lines, -5 lines	0 comments	Download
M	trunk/src/chrome/browser/resources/print_preview/data/ticket_items/color.js	View	2 chunks	+31 lines, -59 lines	0 comments	Download
M	trunk/src/chrome/browser/resources/print_preview/native_layer.js	View	3 chunks	+4 lines, -19 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/webui/print_preview/print_preview_handler.h	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/webui/print_preview/print_preview_handler.cc	View	8 chunks	+81 lines, -6 lines	0 comments	Download
M	trunk/src/chrome/common/chrome_utility_messages.h	View	2 chunks	+7 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/common/cloud_print/cloud_print_cdd_conversion.cc	View	2 chunks	+3 lines, -7 lines	0 comments	Download
M	trunk/src/chrome/test/data/webui/print_preview.js	View	3 chunks	+33 lines, -125 lines	0 comments	Download
M	trunk/src/printing/backend/print_backend.h	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	trunk/src/printing/backend/print_backend.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	trunk/src/printing/backend/print_backend_win.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

Vitaly Buka (NO REVIEWS)

6 years, 6 months ago (2014-06-07 23:48:40 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r275711.