Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 324523002: Generalize printer color model handling, get rid of CUPS specific case. Enable supported paper szes… (Closed)

Created:
6 years, 6 months ago by Aleksey Shlyapnikov
Modified:
6 years, 6 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Visibility:
Public.

Description

Generalize printer color model handling, get rid of CUPS specific case. Enable supported paper szes reporting for all platforms. BUG=239879 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275646 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275716

Patch Set 1 #

Total comments: 5

Patch Set 2 : Use IPC_ENUM_TRAITS_MAX_VALUE instead of IPC_ENUM_TRAITS for color model and duplex mode enums. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+226 lines, -190 lines) Patch
M chrome/browser/resources/print_preview/data/print_ticket_store.js View 1 chunk +5 lines, -11 lines 0 comments Download
M chrome/browser/resources/print_preview/data/ticket_items/color.js View 2 chunks +59 lines, -31 lines 0 comments Download
M chrome/browser/resources/print_preview/native_layer.js View 3 chunks +19 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.h View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.cc View 1 2 8 chunks +6 lines, -81 lines 0 comments Download
M chrome/common/chrome_utility_messages.h View 1 2 chunks +2 lines, -7 lines 0 comments Download
M chrome/common/cloud_print/cloud_print_cdd_conversion.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M chrome/test/data/webui/print_preview.js View 3 chunks +125 lines, -33 lines 0 comments Download
M printing/backend/print_backend.h View 1 chunk +0 lines, -10 lines 0 comments Download
M printing/backend/print_backend.cc View 1 chunk +1 line, -4 lines 0 comments Download
M printing/backend/print_backend_win.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
Aleksey Shlyapnikov
6 years, 6 months ago (2014-06-06 16:47:09 UTC) #1
Vitaly Buka (NO REVIEWS)
lgtm https://codereview.chromium.org/324523002/diff/1/chrome/browser/ui/webui/print_preview/print_preview_handler.cc File chrome/browser/ui/webui/print_preview/print_preview_handler.cc (right): https://codereview.chromium.org/324523002/diff/1/chrome/browser/ui/webui/print_preview/print_preview_handler.cc#newcode320 chrome/browser/ui/webui/print_preview/print_preview_handler.cc:320: color.AddDefaultOption(standard_color, true); why do you need {} here
6 years, 6 months ago (2014-06-06 17:19:25 UTC) #2
Aleksey Shlyapnikov
https://codereview.chromium.org/324523002/diff/1/chrome/browser/ui/webui/print_preview/print_preview_handler.cc File chrome/browser/ui/webui/print_preview/print_preview_handler.cc (right): https://codereview.chromium.org/324523002/diff/1/chrome/browser/ui/webui/print_preview/print_preview_handler.cc#newcode320 chrome/browser/ui/webui/print_preview/print_preview_handler.cc:320: color.AddDefaultOption(standard_color, true); To limit standard_color scope. On 2014/06/06 17:19:25, ...
6 years, 6 months ago (2014-06-06 18:21:20 UTC) #3
Aleksey Shlyapnikov
Justin: for chrome/common/chrome_utility_messages.h changes. Reason for changes: to extend color model, paper sizes and dpi ...
6 years, 6 months ago (2014-06-06 18:23:59 UTC) #4
jschuh
https://codereview.chromium.org/324523002/diff/1/chrome/common/chrome_utility_messages.h File chrome/common/chrome_utility_messages.h (right): https://codereview.chromium.org/324523002/diff/1/chrome/common/chrome_utility_messages.h#newcode51 chrome/common/chrome_utility_messages.h:51: IPC_ENUM_TRAITS(printing::ColorModel) Please declare both of these with IPC_ENUM_TRAITS_MAX_VALUE so ...
6 years, 6 months ago (2014-06-06 18:49:37 UTC) #5
Aleksey Shlyapnikov
https://codereview.chromium.org/324523002/diff/1/chrome/common/chrome_utility_messages.h File chrome/common/chrome_utility_messages.h (right): https://codereview.chromium.org/324523002/diff/1/chrome/common/chrome_utility_messages.h#newcode51 chrome/common/chrome_utility_messages.h:51: IPC_ENUM_TRAITS(printing::ColorModel) On 2014/06/06 18:49:37, Justin Schuh wrote: > Please ...
6 years, 6 months ago (2014-06-06 20:48:56 UTC) #6
jschuh
ipc security lgtm (notes: reusing existing ipc on previously unsupported platforms).
6 years, 6 months ago (2014-06-06 22:01:31 UTC) #7
Aleksey Shlyapnikov
The CQ bit was checked by alekseys@chromium.org
6 years, 6 months ago (2014-06-06 22:08:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alekseys@chromium.org/324523002/20001
6 years, 6 months ago (2014-06-06 22:11:34 UTC) #9
Aleksey Shlyapnikov
The CQ bit was checked by alekseys@chromium.org
6 years, 6 months ago (2014-06-06 22:52:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alekseys@chromium.org/324523002/40001
6 years, 6 months ago (2014-06-06 22:53:42 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-07 04:44:13 UTC) #12
commit-bot: I haz the power
Change committed as 275646
6 years, 6 months ago (2014-06-07 08:29:03 UTC) #13
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/324523002/diff/1/chrome/browser/ui/webui/print_preview/print_preview_handler.cc File chrome/browser/ui/webui/print_preview/print_preview_handler.cc (right): https://codereview.chromium.org/324523002/diff/1/chrome/browser/ui/webui/print_preview/print_preview_handler.cc#newcode320 chrome/browser/ui/webui/print_preview/print_preview_handler.cc:320: color.AddDefaultOption(standard_color, true); On 2014/06/06 18:21:20, Aleksey Shlyapnikov wrote: > ...
6 years, 6 months ago (2014-06-07 23:42:56 UTC) #14
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 6 months ago (2014-06-08 01:46:17 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alekseys@chromium.org/324523002/40001
6 years, 6 months ago (2014-06-08 01:47:23 UTC) #16
commit-bot: I haz the power
Change committed as 275716
6 years, 6 months ago (2014-06-08 02:08:13 UTC) #17
ckocagil
A revert of this CL has been created in https://codereview.chromium.org/321703002/ by ckocagil@chromium.org. The reason for ...
6 years, 6 months ago (2014-06-08 07:55:31 UTC) #18
ckocagil
6 years, 6 months ago (2014-06-08 09:07:42 UTC) #19
Message was sent while issue was closed. 
Sorry for any confusion caused by this second revert, I didn't notice the
previous one. I reverted my revert.

Powered by Google App Engine
This is Rietveld 408576698