IDL compiler: [SetterCallWith]

Source/bindings/scripts/unstable/v8_attributes.py

Index: Source/bindings/scripts/unstable/v8_attributes.py
diff --git a/Source/bindings/scripts/unstable/v8_attributes.py b/Source/bindings/scripts/unstable/v8_attributes.py
index 135af53db1c4804ef3ac81c966d3349ec0041e7b..442ac6de5659cc4ee72d97ce300e9f5fe00f7cc8 100644
--- a/Source/bindings/scripts/unstable/v8_attributes.py
+++ b/Source/bindings/scripts/unstable/v8_attributes.py
@@ -168,7 +168,8 @@ def getter_expression(interface, attribute, contents, includes):
 
     getter_name = scoped_name(interface, attribute, getter_base_name)
 
-    arguments.extend(v8_utilities.call_with_arguments(attribute, contents))
+    call_with = attribute.extended_attributes.get('CallWith', '')

[haraken, 2013/10/21 07:36:52]

Why do we need ", ''" ? I'm a bit afraid that it's easy to forget to add it in
the future.

[Nils Barth (inactive), 2013/10/21 08:03:05]

Changed.

|get| defaults to returning None;
this makes it default to returning ''.

We either need to default to '' or handle None specially.
It's about the same either way, but a bit simpler if we special-case None
in the function.

+    arguments.extend(v8_utilities.call_with_arguments(call_with, contents))
     if attribute.is_nullable:
         arguments.append('isNull')
     if contents['is_getter_raises_exception']:
@@ -219,7 +220,8 @@ def generate_setter(interface, attribute, contents, includes):
 
 
 def setter_expression(interface, attribute, contents, includes):
-    arguments = v8_utilities.call_with_arguments(attribute, contents)
+    call_with = attribute.extended_attributes.get('SetterCallWith') or attribute.extended_attributes.get('CallWith', '')
+    arguments = v8_utilities.call_with_arguments(call_with, contents)
     idl_type = attribute.data_type
     if idl_type == 'EventHandler':
         # FIXME: move V8EventListenerList.h to INCLUDES_FOR_TYPE