chrome/browser/ssl/ssl_blocking_page.cc - Issue 319303003: Polish the new SSL interstitial

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ssl/ssl_blocking_page.cc

Issue 319303003: Polish the new SSL interstitial (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Changes for review Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ssl/ssl_blocking_page.cc

diff --git a/chrome/browser/ssl/ssl_blocking_page.cc b/chrome/browser/ssl/ssl_blocking_page.cc

index 3133c6519609c8a9fd018a7932ad88e10ab1bcd1..4b79463c41929a0b1fe58f97ae55d8e99b9b7727 100644

--- a/chrome/browser/ssl/ssl_blocking_page.cc

+++ b/chrome/browser/ssl/ssl_blocking_page.cc

@@ -420,9 +420,7 @@ std::string SSLBlockingPage::GetHTMLContentsV1() {

std::string SSLBlockingPage::GetHTMLContentsV2() {

base::DictionaryValue loadTimeData;

base::string16 url(ASCIIToUTF16(request_url_.host()));

- bool rtl = base::i18n::IsRTL();

- loadTimeData.SetString("textDirection", rtl ? "rtl" : "ltr");

- if (rtl)

+ if (base::i18n::IsRTL())

base::i18n::WrapStringWithLTRFormatting(&url);

webui::SetFontAndTextDirection(&loadTimeData);

Dan Beam 2014/06/07 03:03:15 can't you just do: loadTimeData.SetDouble("font