chrome/browser/resources/ssl/interstitial_v2.html - Issue 319303003: Polish the new SSL interstitial - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(2898)

My Issues | Starred Open | Closed | All

Unified Diff: chrome/browser/resources/ssl/interstitial_v2.html

Issue 319303003: Polish the new SSL interstitial (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« chrome/browser/resources/ssl/interstitial_v2.css ('K') | « chrome/browser/resources/ssl/interstitial_v2.css ('k') | chrome/browser/ssl/ssl_blocking_page.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/ssl/interstitial_v2.html

diff --git a/chrome/browser/resources/ssl/interstitial_v2.html b/chrome/browser/resources/ssl/interstitial_v2.html

index faaca6a136b1f89410efc48afad9cce77db3a27a..240b0ef77531330577248a7682391a1983f1180b 100644

--- a/chrome/browser/resources/ssl/interstitial_v2.html

+++ b/chrome/browser/resources/ssl/interstitial_v2.html

@@ -1,5 +1,5 @@

<!DOCTYPE html>

-<html i18n-values="dir:textDirection">

+<html i18n-values="dir:textdirection">

<head>

<meta charset="utf-8">

<meta name="viewport"

@@ -11,7 +11,7 @@

<script src="ssl_errors_common.js"></script>

<script src="interstitial_v2.js"></script>

</head>

-<body i18n-values=".style.fontFamily:fontfamily;.style.fontSize:fontsize">

Dan Beam 2014/06/07 02:04:42 ^ why do this? doesn't that mean users' default f

felt 2014/06/07 02:56:12 We want the warnings to be very easy to read. I tr

+<body i18n-values=".style.fontFamily:fontfamily">

<div class="interstitial-wrapper">

<div class="icon"></div>

<div id="main-message">

@@ -24,7 +24,7 @@

</div>

<div id="details" class="hidden">

<p i18n-values=".innerHTML:explanationParagraph"></p>

- <p i18n-values=".innerHTML:finalParagraph"></p>

+ <p i18n-values=".innerHTML:finalParagraph" class="add-top-margin"></p>

Dan Beam 2014/06/07 02:04:42 remove class

felt 2014/06/07 02:56:12 Done.

</div>

</div>

</body>

« chrome/browser/resources/ssl/interstitial_v2.css ('K') | « chrome/browser/resources/ssl/interstitial_v2.css ('k') | chrome/browser/ssl/ssl_blocking_page.cc » ('j') | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698