[Android] Use SetTransformOrigin for glow-effect layers

[Android] Use SetTransformOrigin for glow-effect layers

The effect layers were transformed to the wrong position, as the anchor
point has been replaced with transformed origin in
https://codereview.chromium.org/295193002.

BUG=382087
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275731

[MuVen, 2014-06-07 07:55:41]

PTAL.

Thanks,
MuVen.

[jdduke (slow), 2014-06-07 14:08:03]

Good catch, thanks!  Would you mind shortening the subject to <= 72 chars (why
this isn't automated is beyond me =/), and then in the description go ahead and
link to the causal change (https://codereview.chromium.org/295193002).

Sigh, knowing that the anchor point defaulted to (0.5, 0.5), and could be
overridden, would have saved me a lot of trouble in the past...

[MuVen, 2014-06-07 15:45:09]

On 2014/06/07 14:08:03, jdduke wrote:
> Good catch, thanks!  Would you mind shortening the subject to <= 72 chars (why
> this isn't automated is beyond me =/), and then in the description go ahead
and
> link to the causal change (https://codereview.chromium.org/295193002).
> 
> Sigh, knowing that the anchor point defaulted to (0.5, 0.5), and could be
> overridden, would have saved me a lot of trouble in the past...

done !!!

[jdduke (slow), 2014-06-07 15:50:56]

On 2014/06/07 15:45:09, muven wrote:
> On 2014/06/07 14:08:03, jdduke wrote:
> > Good catch, thanks!  Would you mind shortening the subject to <= 72 chars
(why
> > this isn't automated is beyond me =/), and then in the description go ahead
> and
> > link to the causal change (https://codereview.chromium.org/295193002).
> > 
> > Sigh, knowing that the anchor point defaulted to (0.5, 0.5), and could be
> > overridden, would have saved me a lot of trouble in the past...
> 
> done !!!

Hmm, the patch title will be the first line in the description, so you'll want
to shorten it instead of just wrapping.  Perhaps change it to read something
like:

[Android] Use SetTransformOrigin for glow-effect layers

The effect layers were transformed to the wrong position, as the anchor
point has been replaced with transformed origin in
https://codereview.chromium.org/295193002.

[MuVen, 2014-06-07 16:20:29]

On 2014/06/07 15:50:56, jdduke wrote:
> On 2014/06/07 15:45:09, muven wrote:
> > On 2014/06/07 14:08:03, jdduke wrote:
> > > Good catch, thanks!  Would you mind shortening the subject to <= 72 chars
> (why
> > > this isn't automated is beyond me =/), and then in the description go
ahead
> > and
> > > link to the causal change (https://codereview.chromium.org/295193002).
> > > 
> > > Sigh, knowing that the anchor point defaulted to (0.5, 0.5), and could be
> > > overridden, would have saved me a lot of trouble in the past...
> > 
> > done !!!
> 
> Hmm, the patch title will be the first line in the description, so you'll want
> to shorten it instead of just wrapping.  Perhaps change it to read something
> like:
> 
> [Android] Use SetTransformOrigin for glow-effect layers
> 
> The effect layers were transformed to the wrong position, as the anchor
> point has been replaced with transformed origin in
> https://codereview.chromium.org/295193002.

Thanks.Understood the code-review base etiquette's.
I hope down the lane, i can master this.

[jdduke (slow), 2014-06-07 18:16:31]

On 2014/06/07 16:20:29, muven wrote:
> On 2014/06/07 15:50:56, jdduke wrote:
> > On 2014/06/07 15:45:09, muven wrote:
> > > On 2014/06/07 14:08:03, jdduke wrote:
> > > > Good catch, thanks!  Would you mind shortening the subject to <= 72
chars
> > (why
> > > > this isn't automated is beyond me =/), and then in the description go
> ahead
> > > and
> > > > link to the causal change (https://codereview.chromium.org/295193002).
> > > > 
> > > > Sigh, knowing that the anchor point defaulted to (0.5, 0.5), and could
be
> > > > overridden, would have saved me a lot of trouble in the past...
> > > 
> > > done !!!
> > 
> > Hmm, the patch title will be the first line in the description, so you'll
want
> > to shorten it instead of just wrapping.  Perhaps change it to read something
> > like:
> > 
> > [Android] Use SetTransformOrigin for glow-effect layers
> > 
> > The effect layers were transformed to the wrong position, as the anchor
> > point has been replaced with transformed origin in
> > https://codereview.chromium.org/295193002.
> 
> Thanks.Understood the code-review base etiquette's.
> I hope down the lane, i can master this.

No worries, I probably wasn't very clear.  Note that the issue "description" is
what will be attached to the commit, and the commit's title comes from the first
line of that description.  The issue "title" is just what we see when reviewing
the commit.

In any case I've updated the description, and the fix lgtm, thanks again.

[MuVen, 2014-06-08 01:38:15]

The CQ bit was checked by sataya.m@samsung.com

[commit-bot: I haz the power, 2014-06-08 01:39:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sataya.m@samsung.com/319183011/20001

[commit-bot: I haz the power, 2014-06-08 03:48:14]

Change committed as 275731