Issue 295193002: Get rid of graphics layer anchor points, and replace with transform origin.

Issue 295193002: Get rid of graphics layer anchor points, and replace with transform origin. (Closed)

Created:
6 years, 7 months ago by chrishtr

Modified:
6 years, 6 months ago

Reviewers:
Ian Vollick, sgurun-gerrit only, huangs, enne (OOO)

CC:
chromium-reviews, sievers+watch_chromium.org, jbauman+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, cc-bugs_chromium.org, danakj+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Get rid of graphics layer anchor points, and replace with transform origin. This is the cc side change that listens to transform origin instead of anchor point. Blink is already populating both fields. BUG=372837 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274990

Patch Set 1 #

Patch Set 2 : Fixed. #

Patch Set 3 : Update. #

Patch Set 4 : Fixed. #

Patch Set 5 : Fix. #

Patch Set 6 : Fixed compile. #

Patch Set 7 : Merged. #

Patch Set 8 : Rebaselined. #

Patch Set 9 : Fix compile. #

Patch Set 10 : Fixed. #

Total comments: 8

Patch Set 11 : Fix android webview compile. #

Patch Set 12 : Addressed some comments. #

Patch Set 13 : Addressed all comments. #

Total comments: 2

Patch Set 14 : Cleaned up. #

Total comments: 3

Patch Set 15 : Fix nit. #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+703 lines, -757 lines)			Patch
M	android_webview/browser/hardware_renderer.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14	1 chunk	+0 lines, -1 line	0 comments	Download
M	cc/base/math_util.h	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	cc/base/math_util.cc	View	1 2 3 4	1 chunk	+8 lines, -0 lines	0 comments	Download
M	cc/layers/delegated_renderer_layer_impl_unittest.cc	View	1 2 3 4 5 6 7 8 9 10 11 12	2 chunks	+2 lines, -1 line	0 comments	Download
M	cc/layers/io_surface_layer_impl_unittest.cc	View	1 2 3 4 5 6 7 8 9 10 11	1 chunk	+0 lines, -1 line	0 comments	Download
M	cc/layers/layer.h	View	1 2 3 4	5 chunks	+5 lines, -8 lines	0 comments	Download
M	cc/layers/layer.cc	View	1 2 3	4 chunks	+9 lines, -20 lines	0 comments	Download
M	cc/layers/layer_impl.h	View	1 2 3 4 5 6	3 chunks	+4 lines, -7 lines	0 comments	Download
M	cc/layers/layer_impl.cc	View	1 2 3 4	4 chunks	+6 lines, -16 lines	0 comments	Download
M	cc/layers/layer_impl_unittest.cc	View	1 2 3	5 chunks	+4 lines, -8 lines	0 comments	Download
M	cc/layers/layer_iterator_unittest.cc	View	1 2 3 4 5 6 7 8 9 10 11 12	1 chunk	+0 lines, -1 line	0 comments	Download
M	cc/layers/layer_perftest.cc	View	1 2 3 4 5	3 chunks	+3 lines, -3 lines	0 comments	Download
M	cc/layers/layer_position_constraint_unittest.cc	View		3 chunks	+8 lines, -8 lines	0 comments	Download
M	cc/layers/layer_unittest.cc	View	1 2 3	1 chunk	+2 lines, -3 lines	0 comments	Download
M	cc/layers/layer_utils.cc	View	1 2 3	4 chunks	+15 lines, -12 lines	0 comments	Download
M	cc/layers/layer_utils_unittest.cc	View	1 2 3	4 chunks	+8 lines, -1 line	0 comments	Download
M	cc/layers/nine_patch_layer_impl_unittest.cc	View	1 2 3 4 5 6 7 8 9 10 11 12	1 chunk	+0 lines, -1 line	0 comments	Download
M	cc/layers/painted_scrollbar_layer_impl_unittest.cc	View	1 2 3 4 5 6 7 8 9 10 11 12	1 chunk	+0 lines, -1 line	0 comments	Download
M	cc/layers/picture_layer_impl_unittest.cc	View	1 2 3 4 5 6 7 8 9 10 11 12	1 chunk	+0 lines, -1 line	0 comments	Download
M	cc/layers/render_surface_impl_unittest.cc	View	1 2 3 4 5 6 7 8 9 10 11 12	1 chunk	+0 lines, -1 line	0 comments	Download
M	cc/layers/solid_color_layer_impl_unittest.cc	View	1 2 3 4 5 6 7 8 9 10 11 12	1 chunk	+0 lines, -1 line	0 comments	Download
M	cc/layers/solid_color_scrollbar_layer_impl_unittest.cc	View	1 2 3 4 5 6 7 8 9 10 11 12	1 chunk	+0 lines, -1 line	0 comments	Download
M	cc/layers/surface_layer_impl_unittest.cc	View	1 2 3 4 5 6 7 8 9 10 11 12	1 chunk	+0 lines, -1 line	0 comments	Download
M	cc/layers/texture_layer_impl_unittest.cc	View	1 2 3 4 5 6 7 8 9 10 11 12	1 chunk	+0 lines, -1 line	0 comments	Download
M	cc/layers/texture_layer_unittest.cc	View	1 2 3 4 5 6 7 8 9 10 11 12	8 chunks	+0 lines, -13 lines	0 comments	Download
M	cc/layers/tiled_layer_impl_unittest.cc	View	1 2 3 4 5 6 7 8 9 10 11 12	1 chunk	+0 lines, -1 line	0 comments	Download
M	cc/layers/tiled_layer_unittest.cc	View	1 2 3 4 5 6 7 8 9 10 11 12	2 chunks	+0 lines, -5 lines	0 comments	Download
M	cc/layers/ui_resource_layer_impl_unittest.cc	View	1 2 3 4 5 6 7 8 9 10 11 12	1 chunk	+0 lines, -1 line	0 comments	Download
M	cc/layers/video_layer_impl_unittest.cc	View	1 2 3 4 5 6 7 8 9 10 11 12	1 chunk	+0 lines, -1 line	0 comments	Download
M	cc/test/fake_content_layer.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13	1 chunk	+0 lines, -1 line	0 comments	Download
M	cc/test/fake_painted_scrollbar_layer.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13	1 chunk	+0 lines, -1 line	0 comments	Download
M	cc/test/fake_picture_layer.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	cc/test/layer_tree_host_common_test.h	View	1 2 3	4 chunks	+12 lines, -10 lines	0 comments	Download
M	cc/test/layer_tree_host_common_test.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	cc/test/layer_tree_json_parser.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13	1 chunk	+0 lines, -1 line	0 comments	Download
M	cc/test/layer_tree_pixel_test.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13	3 chunks	+0 lines, -3 lines	0 comments	Download
M	cc/test/layer_tree_test.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	cc/trees/damage_tracker_unittest.cc	View	1 2 3 4 5 6 7 8 9 10 11 12	21 chunks	+14 lines, -27 lines	0 comments	Download
M	cc/trees/layer_tree_host_common.cc	View	1 2 3 4	2 chunks	+14 lines, -18 lines	0 comments	Download
M	cc/trees/layer_tree_host_common_unittest.cc	View	1 2 3 4 5 6 7 8 9 10 11 12	149 chunks	+344 lines, -343 lines	0 comments	Download
M	cc/trees/layer_tree_host_impl_unittest.cc	View	1 2 3 4 5 6 7 8 9 10 11 12	36 chunks	+5 lines, -54 lines	0 comments	Download
M	cc/trees/layer_tree_host_pixeltest_masks.cc	View	1 2 3 4 5 6 7 8 9 10 11 12	7 chunks	+4 lines, -7 lines	0 comments	Download
M	cc/trees/layer_tree_host_pixeltest_on_demand_raster.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13	1 chunk	+0 lines, -1 line	0 comments	Download
M	cc/trees/layer_tree_host_pixeltest_readback.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13	4 chunks	+0 lines, -12 lines	0 comments	Download
M	cc/trees/layer_tree_host_unittest.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14	11 chunks	+3 lines, -14 lines	0 comments	Download
M	cc/trees/layer_tree_host_unittest_context.cc	View	1 2 3 4 5 6 7 8 9 10 11 12	7 chunks	+0 lines, -15 lines	0 comments	Download
M	cc/trees/layer_tree_host_unittest_delegated.cc	View	1 2 3 4 5 6 7 8 9 10 11 12	2 chunks	+0 lines, -2 lines	0 comments	Download
M	cc/trees/layer_tree_host_unittest_occlusion.cc	View	1 2 3 4 5 6 7 8 9 10 11 12	1 chunk	+0 lines, -2 lines	0 comments	Download
M	cc/trees/layer_tree_host_unittest_scroll.cc	View	1 2 3 4 5 6 7 8 9 10 11 12	3 chunks	+0 lines, -3 lines	0 comments	Download
M	cc/trees/layer_tree_host_unittest_video.cc	View	1 2 3 4 5 6 7 8 9 10 11 12	1 chunk	+0 lines, -2 lines	0 comments	Download
M	cc/trees/layer_tree_impl_unittest.cc	View	1 2 3	41 chunks	+184 lines, -84 lines	0 comments	Download
M	cc/trees/occlusion_tracker_unittest.cc	View	1 2 3 4 5 6 7 8 9 10 11 12	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/compositor/compositor.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/compositor/layer.cc	View	1 2 3 4 5 6	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ui/compositor/layer_unittest.cc	View	1 2 3 4 5 6 7 8	3 chunks	+3 lines, -3 lines	0 comments	Download
M	webkit/renderer/compositor_bindings/web_layer_impl.h	View	1 2 3 4 5 6 7 8 9 10 11 12	2 chunks	+9 lines, -4 lines	0 comments	Download
M	webkit/renderer/compositor_bindings/web_layer_impl.cc	View	1 2 3 4 5 6	2 chunks	+21 lines, -14 lines	0 comments	Download
M	webkit/renderer/compositor_bindings/web_layer_impl_fixed_bounds.h	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	webkit/renderer/compositor_bindings/web_layer_impl_fixed_bounds.cc	View	1 2 3 4 5 6 7 8 9 10	2 chunks	+7 lines, -6 lines	0 comments	Download

Messages

Total messages: 29 (0 generated)

Expand Messages | Collapse Messages

enne (OOO)

lgtm https://codereview.chromium.org/295193002/diff/170001/cc/layers/io_surface_layer_impl_unittest.cc File cc/layers/io_surface_layer_impl_unittest.cc (right): https://codereview.chromium.org/295193002/diff/170001/cc/layers/io_surface_layer_impl_unittest.cc#newcode21 cc/layers/io_surface_layer_impl_unittest.cc:21: io_surface_layer_impl->SetTransformOrigin(gfx::Point3F()); I guess this has no transform, so ...

6 years, 6 months ago (2014-06-03 22:25:53 UTC) #2

chrishtr

https://codereview.chromium.org/295193002/diff/170001/cc/layers/io_surface_layer_impl_unittest.cc File cc/layers/io_surface_layer_impl_unittest.cc (right): https://codereview.chromium.org/295193002/diff/170001/cc/layers/io_surface_layer_impl_unittest.cc#newcode21 cc/layers/io_surface_layer_impl_unittest.cc:21: io_surface_layer_impl->SetTransformOrigin(gfx::Point3F()); On 2014/06/03 22:25:52, enne wrote: > I guess ...

6 years, 6 months ago (2014-06-03 23:14:55 UTC) #3

enne (OOO)

https://codereview.chromium.org/295193002/diff/230001/android_webview/browser/hardware_renderer.cc File android_webview/browser/hardware_renderer.cc (right): https://codereview.chromium.org/295193002/diff/230001/android_webview/browser/hardware_renderer.cc#newcode174 android_webview/browser/hardware_renderer.cc:174: delegated_layer_->SetTransformOrigin(gfx::PointF(0.f, 0.f)); It looks like there's a whole bunch ...

6 years, 6 months ago (2014-06-03 23:28:51 UTC) #4

chrishtr

Updated. Hopefully I got them all this time. https://codereview.chromium.org/295193002/diff/230001/android_webview/browser/hardware_renderer.cc File android_webview/browser/hardware_renderer.cc (right): https://codereview.chromium.org/295193002/diff/230001/android_webview/browser/hardware_renderer.cc#newcode174 android_webview/browser/hardware_renderer.cc:174: delegated_layer_->SetTransformOrigin(gfx::PointF(0.f, ...

6 years, 6 months ago (2014-06-03 23:41:55 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/295193002/250001

6 years, 6 months ago (2014-06-04 16:20:25 UTC) #8

Ian Vollick

On 2014/06/04 16:20:25, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...

6 years, 6 months ago (2014-06-04 17:07:02 UTC) #9

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...

6 years, 6 months ago (2014-06-04 17:08:05 UTC) #10

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 6 months ago (2014-06-04 17:13:02 UTC) #11

commit-bot: I haz the power

Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/71613)

6 years, 6 months ago (2014-06-04 17:13:02 UTC) #12

sgurun-gerrit only

On 2014/06/04 17:16:19, chrishtr wrote: > Selim, need your approval for android_webview/... aw lgtm with ...

6 years, 6 months ago (2014-06-04 17:53:42 UTC) #14

sgurun-gerrit only

On 2014/06/04 17:16:19, chrishtr wrote: > Selim, need your approval for android_webview/... aw lgtm with ...

6 years, 6 months ago (2014-06-04 17:53:45 UTC) #15

sgurun-gerrit only

https://codereview.chromium.org/295193002/diff/250001/android_webview/browser/hardware_renderer.cc File android_webview/browser/hardware_renderer.cc (right): https://codereview.chromium.org/295193002/diff/250001/android_webview/browser/hardware_renderer.cc#newcode171 android_webview/browser/hardware_renderer.cc:171: delegated_layer_ = cc::DelegatedRendererLayer::Create(frame_provider_); nit: indention

6 years, 6 months ago (2014-06-04 17:53:59 UTC) #16

chrishtr

6 years, 6 months ago (2014-06-04 17:56:33 UTC) #17

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/295193002/270001

6 years, 6 months ago (2014-06-04 17:58:41 UTC) #19

enne (OOO)

6 years, 6 months ago (2014-06-04 18:03:18 UTC) #20

enne (OOO)

On 2014/06/04 18:03:18, enne wrote: > https://codereview.chromium.org/295193002/diff/250001/android_webview/browser/hardware_renderer.cc > File android_webview/browser/hardware_renderer.cc (right): > > https://codereview.chromium.org/295193002/diff/250001/android_webview/browser/hardware_renderer.cc#newcode171 > ...

6 years, 6 months ago (2014-06-04 18:03:37 UTC) #21

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium ...

6 years, 6 months ago (2014-06-04 21:41:44 UTC) #22

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 6 months ago (2014-06-04 21:48:07 UTC) #23

commit-bot: I haz the power

Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_compile_rel/builds/10573)

6 years, 6 months ago (2014-06-04 21:48:08 UTC) #24

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/295193002/270001

6 years, 6 months ago (2014-06-05 03:03:46 UTC) #26

huangs

I think LayerWithNullDelegateTest.SwitchLayerPreservesCCLayerState is broken: http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/11394 It probably can be fixed in https://codereview.chromium.org/295193002/diff/270001/ui/compositor/layer_unittest.cc by replacing ...

6 years, 6 months ago (2014-06-05 06:07:36 UTC) #28

darin (slow to review)

6 years, 6 months ago (2014-06-05 06:18:07 UTC) #29

Message was sent while issue was closed.

On 2014/06/05 06:07:36, huangs1 wrote:
> I think 
> 
> LayerWithNullDelegateTest.SwitchLayerPreservesCCLayerState
> 
> is broken:
> 
> http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/11394
> 
> It probably can be fixed in
> 
>
https://codereview.chromium.org/295193002/diff/270001/ui/compositor/layer_uni...
> 
> by replacing expect results to use Point3F() instead.  fishd@ is looking into
> this, but please verify later that this is a proper fix.

Fix is here:
https://codereview.chromium.org/314053002/

Expand Messages | Collapse Messages