Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1733)

Issue 319183006: Move GraphicsLayerUpdater::rebuildTree into its own file (Closed)

Created:
6 years, 6 months ago by abarth-chromium
Modified:
6 years, 6 months ago
Reviewers:
esprehn
CC:
esprehn, blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, ojan, pdr., rune+blink, Ian Vollick, zoltan1
Visibility:
Public.

Description

Move GraphicsLayerUpdater::rebuildTree into its own file GraphicsLayerUpdater::rebuildTree and GraphicsLayerUpdater::update no longer have anything to do with each other. This CL move rebuildTree into a separate file, called GraphicsLayerTreeBuilder. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175731

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -168 lines) Patch
M Source/core/core.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
A + Source/core/rendering/compositing/GraphicsLayerTreeBuilder.h View 2 chunks +15 lines, -8 lines 0 comments Download
A + Source/core/rendering/compositing/GraphicsLayerTreeBuilder.cpp View 1 5 chunks +13 lines, -82 lines 0 comments Download
M Source/core/rendering/compositing/GraphicsLayerUpdater.cpp View 1 2 chunks +0 lines, -76 lines 0 comments Download
M Source/core/rendering/compositing/RenderLayerCompositor.cpp View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
abarth-chromium
6 years, 6 months ago (2014-06-06 20:14:57 UTC) #1
esprehn
rslgtm, seems it doesn't apply though.
6 years, 6 months ago (2014-06-06 21:46:04 UTC) #2
abarth-chromium
On 2014/06/06 21:46:04, esprehn wrote: > rslgtm, seems it doesn't apply though. Yeah, it's part ...
6 years, 6 months ago (2014-06-06 22:36:26 UTC) #3
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 6 months ago (2014-06-06 22:43:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/319183006/20001
6 years, 6 months ago (2014-06-06 22:44:33 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-06 23:41:31 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 23:49:29 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/10701)
6 years, 6 months ago (2014-06-06 23:49:30 UTC) #8
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 6 months ago (2014-06-07 00:12:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/319183006/20001
6 years, 6 months ago (2014-06-07 00:13:42 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-07 01:17:40 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-07 03:47:56 UTC) #12
Message was sent while issue was closed.
Change committed as 175731

Powered by Google App Engine
This is Rietveld 408576698