Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 319133006: ozone: gestures: Fix multiple clicking (Closed)

Created:
6 years, 6 months ago by spang
Modified:
6 years, 6 months ago
Reviewers:
rjkroege, sadrul
CC:
chromium-reviews, rjkroege, kalyank, tdresser+watch_chromium.org, ozone-reviews_chromium.org
Visibility:
Public.

Description

ozone: gestures: Fix multiple clicking Double-clicking is broken because we didn't hit the repeat count path. Someday we will not have NativeEvent and this insanity will go away. BUG=323965 TEST=link_freon double clicking NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276438

Patch Set 1 #

Patch Set 2 : add todo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.cc View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
spang
6 years, 6 months ago (2014-06-09 15:08:29 UTC) #1
sadrul
yikes. You should add a comment explaining why this is necessary. With that, lgtm We ...
6 years, 6 months ago (2014-06-11 16:36:34 UTC) #2
rjkroege
I'm with sadrul: this is disturbingly grotty.
6 years, 6 months ago (2014-06-11 17:00:04 UTC) #3
spang
On 2014/06/11 17:00:04, rjkroege wrote: > I'm with sadrul: this is disturbingly grotty. what's grotty ...
6 years, 6 months ago (2014-06-11 17:03:09 UTC) #4
spang
The CQ bit was checked by spang@chromium.org
6 years, 6 months ago (2014-06-11 17:31:23 UTC) #5
spang
The CQ bit was unchecked by spang@chromium.org
6 years, 6 months ago (2014-06-11 17:33:42 UTC) #6
spang
The CQ bit was checked by spang@chromium.org
6 years, 6 months ago (2014-06-11 17:33:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/319133006/10001
6 years, 6 months ago (2014-06-11 17:35:17 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 17:38:48 UTC) #9
Message was sent while issue was closed.
Change committed as 276438

Powered by Google App Engine
This is Rietveld 408576698