Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 319133003: Initialize the bitmap before drawing the VideoFrame into it, in case (Closed)

Created:
6 years, 6 months ago by danakj
Modified:
6 years, 6 months ago
Reviewers:
no sievers, reed1
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, miu+watch_chromium.org
Visibility:
Public.

Description

Initialize the bitmap before drawing the VideoFrame into it, in case not everything in the video frame is opaque. R=reed@google.com, sievers@chromium.org BUG=380680 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275511

Patch Set 1 #

Total comments: 3

Patch Set 2 : initbitmap: . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/renderer_host/render_widget_host_view_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
danakj
6 years, 6 months ago (2014-06-06 14:46:57 UTC) #1
reed1
https://codereview.chromium.org/319133003/diff/1/content/browser/renderer_host/render_widget_host_view_browsertest.cc File content/browser/renderer_host/render_widget_host_view_browsertest.cc (right): https://codereview.chromium.org/319133003/diff/1/content/browser/renderer_host/render_widget_host_view_browsertest.cc#newcode495 content/browser/renderer_host/render_widget_host_view_browsertest.cc:495: bitmap.allocPixels(); While we're editing this file... I see there ...
6 years, 6 months ago (2014-06-06 15:46:30 UTC) #2
danakj
https://codereview.chromium.org/319133003/diff/1/content/browser/renderer_host/render_widget_host_view_browsertest.cc File content/browser/renderer_host/render_widget_host_view_browsertest.cc (right): https://codereview.chromium.org/319133003/diff/1/content/browser/renderer_host/render_widget_host_view_browsertest.cc#newcode495 content/browser/renderer_host/render_widget_host_view_browsertest.cc:495: bitmap.allocPixels(); On 2014/06/06 15:46:30, reed1 wrote: > While we're ...
6 years, 6 months ago (2014-06-06 15:47:21 UTC) #3
no sievers
lgtm
6 years, 6 months ago (2014-06-06 17:16:54 UTC) #4
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 6 months ago (2014-06-06 17:20:53 UTC) #5
danakj
https://codereview.chromium.org/319133003/diff/1/content/browser/renderer_host/render_widget_host_view_browsertest.cc File content/browser/renderer_host/render_widget_host_view_browsertest.cc (right): https://codereview.chromium.org/319133003/diff/1/content/browser/renderer_host/render_widget_host_view_browsertest.cc#newcode495 content/browser/renderer_host/render_widget_host_view_browsertest.cc:495: bitmap.allocPixels(); On 2014/06/06 15:47:21, danakj wrote: > On 2014/06/06 ...
6 years, 6 months ago (2014-06-06 17:21:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/319133003/20001
6 years, 6 months ago (2014-06-06 17:23:34 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 20:29:45 UTC) #8
Message was sent while issue was closed. 
Change committed as 275511

Powered by Google App Engine
This is Rietveld 408576698