Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1353)

Side by Side Diff: content/browser/renderer_host/render_widget_host_view_browsertest.cc

Issue 319133003: Initialize the bitmap before drawing the VideoFrame into it, in case (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: initbitmap: . Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/message_loop/message_loop_proxy.h" 6 #include "base/message_loop/message_loop_proxy.h"
7 #include "base/path_service.h" 7 #include "base/path_service.h"
8 #include "base/run_loop.h" 8 #include "base/run_loop.h"
9 #include "content/browser/gpu/compositor_util.h" 9 #include "content/browser/gpu/compositor_util.h"
10 #include "content/browser/gpu/gpu_data_manager_impl.h" 10 #include "content/browser/gpu/gpu_data_manager_impl.h"
(...skipping 474 matching lines...) Expand 10 before | Expand all | Expand 10 after
485 return; 485 return;
486 } 486 }
487 487
488 media::SkCanvasVideoRenderer video_renderer; 488 media::SkCanvasVideoRenderer video_renderer;
489 489
490 SkBitmap bitmap; 490 SkBitmap bitmap;
491 bitmap.allocPixels(SkImageInfo::Make(video_frame->visible_rect().width(), 491 bitmap.allocPixels(SkImageInfo::Make(video_frame->visible_rect().width(),
492 video_frame->visible_rect().height(), 492 video_frame->visible_rect().height(),
493 kPMColor_SkColorType, 493 kPMColor_SkColorType,
494 kPremul_SkAlphaType)); 494 kPremul_SkAlphaType));
495 bitmap.allocPixels(); 495 bitmap.eraseColor(SK_ColorTRANSPARENT);
496 SkCanvas canvas(bitmap); 496 SkCanvas canvas(bitmap);
497 497
498 video_renderer.Paint(video_frame.get(), 498 video_renderer.Paint(video_frame.get(),
499 &canvas, 499 &canvas,
500 video_frame->visible_rect(), 500 video_frame->visible_rect(),
501 0xff); 501 0xff);
502 502
503 CopyFromCompositingSurfaceCallback(quit_callback, 503 CopyFromCompositingSurfaceCallback(quit_callback,
504 result, 504 result,
505 bitmap); 505 bitmap);
(...skipping 351 matching lines...) Expand 10 before | Expand all | Expand 10 after
857 CompositingRenderWidgetHostViewBrowserTestTabCapture, 857 CompositingRenderWidgetHostViewBrowserTestTabCapture,
858 testing::ValuesIn(kAllCompositingModes)); 858 testing::ValuesIn(kAllCompositingModes));
859 INSTANTIATE_TEST_CASE_P(GLAndSoftwareCompositing, 859 INSTANTIATE_TEST_CASE_P(GLAndSoftwareCompositing,
860 CompositingRenderWidgetHostViewTabCaptureHighDPI, 860 CompositingRenderWidgetHostViewTabCaptureHighDPI,
861 testing::ValuesIn(kAllCompositingModes)); 861 testing::ValuesIn(kAllCompositingModes));
862 862
863 #endif // !defined(OS_ANDROID) && !defined(OS_IOS) 863 #endif // !defined(OS_ANDROID) && !defined(OS_IOS)
864 864
865 } // namespace 865 } // namespace
866 } // namespace content 866 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698