Issue 319083004: Oilpan: add Element/Node Member fields to stack allocated objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 319083004: Oilpan: add Element/Node Member fields to stack allocated objects. (Closed)

Created:
6 years, 6 months ago by sof

Modified:
6 years, 6 months ago

Reviewers:
oilpan-reviews, haraken, tkent

CC:
blink-reviews, blink-reviews-html_chromium.org, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Oilpan: add Element/Node Member fields to stack allocated objects. Tidy up the definition of some stack objects and have them refer to Element or Node references by way of Members rather than raw pointers. R=tkent@chromium.org,haraken@chromium.org BUG=357163 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175646

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+60 lines, -51 lines)			Patch
M	Source/core/dom/PositionIterator.h	View	2 chunks	+5 lines, -4 lines	0 comments	Download
M	Source/core/dom/PositionIterator.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/RenderTreeBuilder.h	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	Source/core/dom/SelectorQuery.cpp	View	3 chunks	+7 lines, -6 lines	0 comments	Download
M	Source/core/dom/shadow/ComposedTreeWalker.h	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	Source/core/editing/TextIterator.h	View	8 chunks	+16 lines, -12 lines	0 comments	Download
M	Source/core/editing/TextIterator.cpp	View	12 chunks	+22 lines, -22 lines	0 comments	Download
M	Source/core/html/LinkResource.h	View	2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/319083004/1

6 years, 6 months ago (2014-06-06 07:40:40 UTC) #5

Message was sent while issue was closed.

Change committed as 175646

Expand Messages | Collapse Messages