Chromium Code Reviews

Issue 319083004: Oilpan: add Element/Node Member fields to stack allocated objects. (Closed)

Created:
6 years, 6 months ago by sof
Modified:
6 years, 6 months ago
Reviewers:
oilpan-reviews, haraken, tkent
CC:
blink-reviews, blink-reviews-html_chromium.org, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Oilpan: add Element/Node Member fields to stack allocated objects. Tidy up the definition of some stack objects and have them refer to Element or Node references by way of Members rather than raw pointers. R=tkent@chromium.org,haraken@chromium.org BUG=357163 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175646

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+60 lines, -51 lines)
M Source/core/dom/PositionIterator.h View 2 chunks +5 lines, -4 lines 0 comments
M Source/core/dom/PositionIterator.cpp View 1 chunk +1 line, -1 line 0 comments
M Source/core/dom/RenderTreeBuilder.h View 2 chunks +4 lines, -3 lines 0 comments
M Source/core/dom/SelectorQuery.cpp View 3 chunks +7 lines, -6 lines 0 comments
M Source/core/dom/shadow/ComposedTreeWalker.h View 3 chunks +3 lines, -2 lines 0 comments
M Source/core/editing/TextIterator.h View 8 chunks +16 lines, -12 lines 0 comments
M Source/core/editing/TextIterator.cpp View 12 chunks +22 lines, -22 lines 0 comments
M Source/core/html/LinkResource.h View 2 chunks +2 lines, -1 line 0 comments

Messages

Total messages: 6 (0 generated)
sof
Please take a look.
6 years, 6 months ago (2014-06-06 07:11:40 UTC) #1
tkent
lgtm
6 years, 6 months ago (2014-06-06 07:13:34 UTC) #2
haraken
LGTM
6 years, 6 months ago (2014-06-06 07:21:01 UTC) #3
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 6 months ago (2014-06-06 07:40:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/319083004/1
6 years, 6 months ago (2014-06-06 07:40:40 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 08:33:05 UTC) #6
Message was sent while issue was closed.
Change committed as 175646

Powered by Google App Engine