Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Side by Side Diff: Source/core/dom/RenderTreeBuilder.h

Issue 319083004: Oilpan: add Element/Node Member fields to stack allocated objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/dom/PositionIterator.cpp ('k') | Source/core/dom/SelectorQuery.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 6 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
7 * Copyright (C) 2011 Google Inc. All rights reserved. 7 * Copyright (C) 2011 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 20 matching lines...) Expand all
31 #include "core/dom/NodeRenderingTraversal.h" 31 #include "core/dom/NodeRenderingTraversal.h"
32 #include "wtf/RefPtr.h" 32 #include "wtf/RefPtr.h"
33 33
34 namespace WebCore { 34 namespace WebCore {
35 35
36 class ContainerNode; 36 class ContainerNode;
37 class RenderObject; 37 class RenderObject;
38 class RenderStyle; 38 class RenderStyle;
39 39
40 class RenderTreeBuilder { 40 class RenderTreeBuilder {
41 STACK_ALLOCATED();
41 public: 42 public:
42 RenderTreeBuilder(Node* node, RenderStyle* style) 43 RenderTreeBuilder(Node* node, RenderStyle* style)
43 : m_node(node) 44 : m_node(node)
44 , m_renderingParent(0) 45 , m_renderingParent(nullptr)
45 , m_style(style) 46 , m_style(style)
46 { 47 {
47 ASSERT(!node->renderer()); 48 ASSERT(!node->renderer());
48 ASSERT(node->needsAttach()); 49 ASSERT(node->needsAttach());
49 ASSERT(node->document().inStyleRecalc()); 50 ASSERT(node->document().inStyleRecalc());
50 51
51 // FIXME: We should be able to ASSERT(node->inActiveDocument()) but chil drenChanged is called 52 // FIXME: We should be able to ASSERT(node->inActiveDocument()) but chil drenChanged is called
52 // before ChildNodeInsertionNotifier in ContainerNode's methods and some implementations 53 // before ChildNodeInsertionNotifier in ContainerNode's methods and some implementations
53 // will trigger a layout inside childrenChanged. 54 // will trigger a layout inside childrenChanged.
54 // Mainly HTMLTextAreaElement::childrenChanged calls HTMLTextFormControl Element::setSelectionRange 55 // Mainly HTMLTextAreaElement::childrenChanged calls HTMLTextFormControl Element::setSelectionRange
55 // which does an updateLayoutIgnorePendingStylesheets. 56 // which does an updateLayoutIgnorePendingStylesheets.
56 57
57 m_renderingParent = NodeRenderingTraversal::parent(node, &m_parentDetail s); 58 m_renderingParent = NodeRenderingTraversal::parent(node, &m_parentDetail s);
58 } 59 }
59 60
60 void createRendererForTextIfNeeded(); 61 void createRendererForTextIfNeeded();
61 void createRendererForElementIfNeeded(); 62 void createRendererForElementIfNeeded();
62 63
63 private: 64 private:
64 RenderObject* parentRenderer() const; 65 RenderObject* parentRenderer() const;
65 RenderObject* nextRenderer() const; 66 RenderObject* nextRenderer() const;
66 bool shouldCreateRenderer() const; 67 bool shouldCreateRenderer() const;
67 RenderStyle& style() const; 68 RenderStyle& style() const;
68 69
69 Node* m_node; 70 RawPtrWillBeMember<Node> m_node;
70 ContainerNode* m_renderingParent; 71 RawPtrWillBeMember<ContainerNode> m_renderingParent;
71 NodeRenderingTraversal::ParentDetails m_parentDetails; 72 NodeRenderingTraversal::ParentDetails m_parentDetails;
72 mutable RefPtr<RenderStyle> m_style; 73 mutable RefPtr<RenderStyle> m_style;
73 }; 74 };
74 75
75 } // namespace WebCore 76 } // namespace WebCore
76 77
77 #endif 78 #endif
OLDNEW
« no previous file with comments | « Source/core/dom/PositionIterator.cpp ('k') | Source/core/dom/SelectorQuery.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698