Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: tools/cygprofile/mergetraces_unittest.py

Issue 319053004: Fix bug in mergetraces.py. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/cygprofile/mergetraces.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/cygprofile/mergetraces_unittest.py
diff --git a/tools/cygprofile/mergetraces_unittest.py b/tools/cygprofile/mergetraces_unittest.py
index 5a00bd6d9a03a0450a0a329f62c4cc0a1f38c6cc..0aa68c6614e3abfc2caab4624a97a8588a112a72 100644
--- a/tools/cygprofile/mergetraces_unittest.py
+++ b/tools/cygprofile/mergetraces_unittest.py
@@ -12,11 +12,11 @@ class GroupByProcessAndThreadIdTest(unittest.TestCase):
input_trace = [
(100, 10, '2000:2001', 0x5),
(100, 11, '2000:2001', 0x3),
- (100, 11, '2000:2000', 0x1),
- (100, 12, '2001:2001', 0x6),
(100, 13, '2000:2002', 0x8),
- (100, 13, '2001:2002', 0x9),
- (100, 14, '2000:2000', 0x7)
+ (100, 14, '2000:2000', 0x7),
+ (120, 13, '2001:2002', 0x9),
+ (150, 12, '2001:2001', 0x6),
+ (180, 11, '2000:2000', 0x1),
]
# Functions should be grouped by thread-id and PIDs should not be
@@ -24,11 +24,11 @@ class GroupByProcessAndThreadIdTest(unittest.TestCase):
expected_trace = [
(100, 10, '2000:2001', 0x5),
(100, 11, '2000:2001', 0x3),
- (100, 11, '2000:2000', 0x1),
- (100, 14, '2000:2000', 0x7),
(100, 13, '2000:2002', 0x8),
- (100, 12, '2001:2001', 0x6),
- (100, 13, '2001:2002', 0x9)
+ (100, 14, '2000:2000', 0x7),
+ (180, 11, '2000:2000', 0x1),
+ (150, 12, '2001:2001', 0x6),
pasko 2014/06/06 09:14:15 please make sure each tid uniquely identifies the
Philippe 2014/06/06 09:30:48 Done.
+ (120, 13, '2001:2002', 0x9),
]
grouped_trace = mergetraces.GroupByProcessAndThreadId(input_trace)
« no previous file with comments | « tools/cygprofile/mergetraces.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698