Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Unified Diff: tools/cygprofile/mergetraces.py

Issue 319053004: Fix bug in mergetraces.py. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/cygprofile/mergetraces_unittest.py » ('j') | tools/cygprofile/mergetraces_unittest.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/cygprofile/mergetraces.py
diff --git a/tools/cygprofile/mergetraces.py b/tools/cygprofile/mergetraces.py
index f349ad3b885374cada16b86b1cc2c2ed2018f4da..9eb5e0025ad5dc011ff9f854ae5085ceaff8af80 100755
--- a/tools/cygprofile/mergetraces.py
+++ b/tools/cygprofile/mergetraces.py
@@ -143,8 +143,8 @@ def GroupByProcessAndThreadId(input_trace):
result each thread has its own contiguous segment of code (ordered by
timestamp) and processes also have their code isolated (i.e. not interleaved).
"""
- def MakeTimestamp(usec, sec):
- return usec * 1000000 + sec
+ def MakeTimestamp(sec, usec):
+ return sec * 1000000 + usec
def PidAndTidFromString(pid_and_tid):
strings = pid_and_tid.split(':')
@@ -155,9 +155,9 @@ def GroupByProcessAndThreadId(input_trace):
for (sec, usec, pid_and_tid, _) in input_trace:
(pid, tid) = PidAndTidFromString(pid_and_tid)
if not pid in pid_first_seen:
- pid_first_seen[pid] = MakeTimestamp(usec, sec)
+ pid_first_seen[pid] = MakeTimestamp(sec, usec)
if not tid in tid_first_seen:
- tid_first_seen[tid] = MakeTimestamp(usec, sec)
+ tid_first_seen[tid] = MakeTimestamp(sec, usec)
def CompareEvents(event1, event2):
(sec1, usec1, pid_and_tid, _) = event1
@@ -171,7 +171,7 @@ def GroupByProcessAndThreadId(input_trace):
tid_cmp = cmp(tid_first_seen[tid1], tid_first_seen[tid2])
if tid_cmp != 0:
return tid_cmp
- return cmp(MakeTimestamp(usec1, sec1), MakeTimestamp(usec2, sec2))
+ return cmp(MakeTimestamp(sec1, usec1), MakeTimestamp(sec2, usec2))
return sorted(input_trace, cmp=CompareEvents)
« no previous file with comments | « no previous file | tools/cygprofile/mergetraces_unittest.py » ('j') | tools/cygprofile/mergetraces_unittest.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698