Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 318973002: DevTools: Allow using test shell apps for port forwarding (Closed)

Created:
6 years, 6 months ago by Vladislav Kaznacheev
Modified:
6 years, 6 months ago
CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

DevTools: Allow using test shell apps for port forwarding BUG=380356 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276602

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/devtools/device/port_forwarding_controller.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Vladislav Kaznacheev
6 years, 6 months ago (2014-06-05 15:00:59 UTC) #1
mnaganov (inactive)
lgtm
6 years, 6 months ago (2014-06-05 15:03:31 UTC) #2
pfeldman
The CQ bit was checked by pfeldman@chromium.org
6 years, 6 months ago (2014-06-11 18:51:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/318973002/1
6 years, 6 months ago (2014-06-11 18:54:58 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 22:52:21 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 22:54:00 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/builds/38114)
6 years, 6 months ago (2014-06-11 22:54:01 UTC) #7
pfeldman
The CQ bit was checked by pfeldman@chromium.org
6 years, 6 months ago (2014-06-12 04:37:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/318973002/1
6 years, 6 months ago (2014-06-12 04:40:09 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 09:32:18 UTC) #10
Message was sent while issue was closed. 
Change committed as 276602

Powered by Google App Engine
This is Rietveld 408576698