chrome/browser/devtools/device/port_forwarding_controller.cc - Issue 318973002: DevTools: Allow using test shell apps for port forwarding

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/device/port_forwarding_controller.cc

Issue 318973002: DevTools: Allow using test shell apps for port forwarding (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/devtools/device/port_forwarding_controller.cc

diff --git a/chrome/browser/devtools/device/port_forwarding_controller.cc b/chrome/browser/devtools/device/port_forwarding_controller.cc

index 8efda7d84d5be6c5d908388eb81f7312f498ea02..df610d199221fb35357ad699cf2d8bae1ccd4be0 100644

--- a/chrome/browser/devtools/device/port_forwarding_controller.cc

+++ b/chrome/browser/devtools/device/port_forwarding_controller.cc

@@ -242,8 +242,7 @@ FindBestBrowserForTethering(

browsers.begin(); it != browsers.end(); ++it) {

scoped_refptr<DevToolsAndroidBridge::RemoteBrowser> browser = *it;

ParsedVersion current_version = browser->GetParsedVersion();

- if (browser->IsChrome() &&

- IsPortForwardingSupported(current_version) &&

+ if (IsPortForwardingSupported(current_version) &&

IsVersionLower(newest_version, current_version)) {

best_browser = browser;

newest_version = current_version;

« no previous file with comments | « no previous file | no next file » | no next file with comments »