src/effects/gradients/SkTwoPointRadialGradient.h - Issue 318923005: SkShader::asNewEffect Refactoring

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/gradients/SkTwoPointRadialGradient.h

Issue 318923005: SkShader::asNewEffect Refactoring (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Style corrections Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/gradients/SkTwoPointRadialGradient.h

diff --git a/src/effects/gradients/SkTwoPointRadialGradient.h b/src/effects/gradients/SkTwoPointRadialGradient.h

index 90052eba20eea2793c9b23d769250b791bbf5b6a..0cd7a5c78e9ede8f2635481acac4d30b0348c0f2 100644

--- a/src/effects/gradients/SkTwoPointRadialGradient.h

+++ b/src/effects/gradients/SkTwoPointRadialGradient.h

@@ -21,8 +21,8 @@ public:

SkMatrix* matrix,

TileMode* xy) const SK_OVERRIDE;

virtual GradientType asAGradient(GradientInfo* info) const SK_OVERRIDE;

- virtual GrEffectRef* asNewEffect(GrContext* context, const SkPaint&,

- const SkMatrix*) const SK_OVERRIDE;

+ virtual bool asNewEffect(GrContext* context, const SkPaint&, GrColor*, GrEffectRef**,

+ const SkMatrix*) const SK_OVERRIDE;

virtual size_t contextSize() const SK_OVERRIDE;