src/effects/gradients/SkLinearGradient.h - Issue 318923005: SkShader::asNewEffect Refactoring

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/gradients/SkLinearGradient.h

Issue 318923005: SkShader::asNewEffect Refactoring (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Style corrections Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/gradients/SkLinearGradient.h

diff --git a/src/effects/gradients/SkLinearGradient.h b/src/effects/gradients/SkLinearGradient.h

index 432dac0ff8fff73f715556b5219826dc6ba0d19d..bdca1ddb620e3bfe7dc1684eddc61fecb64c3964 100644

--- a/src/effects/gradients/SkLinearGradient.h

+++ b/src/effects/gradients/SkLinearGradient.h

@@ -30,7 +30,8 @@ public:

virtual BitmapType asABitmap(SkBitmap*, SkMatrix*, TileMode*) const SK_OVERRIDE;

virtual GradientType asAGradient(GradientInfo* info) const SK_OVERRIDE;

- virtual GrEffectRef* asNewEffect(GrContext*, const SkPaint&, const SkMatrix*) const SK_OVERRIDE;

+ virtual bool asNewEffect(GrContext* context, const SkPaint& paint, GrColor* grColor,

+ GrEffectRef** grEffect, const SkMatrix* localMatrix) const SK_OVERRIDE;

SK_TO_STRING_OVERRIDE()

SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(SkLinearGradient)