src/core/SkShader.cpp - Issue 318923005: SkShader::asNewEffect Refactoring

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkShader.cpp

Issue 318923005: SkShader::asNewEffect Refactoring (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Style corrections Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkShader.cpp

diff --git a/src/core/SkShader.cpp b/src/core/SkShader.cpp

index 9484db59c18837ac6feaa767cbff03a05cc78613..83053cae8e728546b561de219880dac795f08466 100644

--- a/src/core/SkShader.cpp

+++ b/src/core/SkShader.cpp

@@ -208,8 +208,10 @@ SkShader::GradientType SkShader::asAGradient(GradientInfo* info) const {

return kNone_GradientType;

}

-GrEffectRef* SkShader::asNewEffect(GrContext*, const SkPaint&, const SkMatrix*) const {

- return NULL;

+bool SkShader::asNewEffect(GrContext* context, const SkPaint& paint, GrColor* grColor,

+ GrEffectRef** grEffect, const SkMatrix* localMatrixOrNull) const {

+ *grEffect = NULL;

+ return false;

}

SkShader* SkShader::refAsALocalMatrixShader(SkMatrix*) const {