Source/core/html/HTMLMediaElement.h - Issue 318923004: Eliminate MediaPlayer & MediaPlayerClient abstractions(readystate)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLMediaElement.h

Issue 318923004: Eliminate MediaPlayer & MediaPlayerClient abstractions(readystate) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLMediaElement.h

diff --git a/Source/core/html/HTMLMediaElement.h b/Source/core/html/HTMLMediaElement.h

index c7117ed3b1e6e4b6cc1d1c98f9d5a35ebbae31be..bcb8673ef3baca736b7fc1153b6bd04d4937c9ac 100644

--- a/Source/core/html/HTMLMediaElement.h

+++ b/Source/core/html/HTMLMediaElement.h

@@ -324,7 +324,7 @@ private:

virtual void updateDisplayState() { }

- void setReadyState(MediaPlayer::ReadyState);

+ void setReadyState(blink::WebMediaPlayer::ReadyState);

acolwell GONE FROM CHROMIUM 2014/06/06 05:51:09 nit: I think it makes more sense to use ReadyState

Srirama 2014/06/06 06:41:41 Done.

void setNetworkState(MediaPlayer::NetworkState);

virtual void mediaPlayerNetworkStateChanged() OVERRIDE FINAL;

« no previous file with comments | « no previous file | Source/core/html/HTMLMediaElement.cpp » ('j') | Source/modules/imagebitmap/ImageBitmapFactories.cpp » ('J')