Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(977)

Unified Diff: Source/core/html/HTMLMediaElement.cpp

Issue 318923004: Eliminate MediaPlayer & MediaPlayerClient abstractions(readystate) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLMediaElement.cpp
diff --git a/Source/core/html/HTMLMediaElement.cpp b/Source/core/html/HTMLMediaElement.cpp
index 380683b173f4715adebd76644a288b3f03b27a4b..9cfdf6e7f51cf27e4aa4ec678d254cd1bbab57e6 100644
--- a/Source/core/html/HTMLMediaElement.cpp
+++ b/Source/core/html/HTMLMediaElement.cpp
@@ -1232,9 +1232,9 @@ bool HTMLMediaElement::textTracksAreReady() const
void HTMLMediaElement::textTrackReadyStateChanged(TextTrack* track)
{
- if (m_player && m_textTracksWhenResourceSelectionBegan.contains(track)) {
+ if (webMediaPlayer()&& m_textTracksWhenResourceSelectionBegan.contains(track)) {
if (track->readinessState() != TextTrack::Loading)
- setReadyState(m_player->readyState());
+ setReadyState(webMediaPlayer()->readyState());
} else {
// The track readiness state might have changed as a result of the user
// clicking the captions button. In this case, a check whether all the
@@ -1586,10 +1586,10 @@ void HTMLMediaElement::changeNetworkStateFromLoadingToIdle()
void HTMLMediaElement::mediaPlayerReadyStateChanged()
{
- setReadyState(m_player->readyState());
+ setReadyState(webMediaPlayer()->readyState());
}
-void HTMLMediaElement::setReadyState(MediaPlayer::ReadyState state)
+void HTMLMediaElement::setReadyState(WebMediaPlayer::ReadyState state)
{
WTF_LOG(Media, "HTMLMediaElement::setReadyState(%d) - current state is %d,", static_cast<int>(state), static_cast<int>(m_readyState));

Powered by Google App Engine
This is Rietveld 408576698