Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 318863008: Move ExtensionServiceTestBase into it's own header/cc file (Closed)

Created:
6 years, 6 months ago by Devlin
Modified:
6 years, 6 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, chromium-apps-reviews_chromium.org, pam+watch_chromium.org, tfarina, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Move ExtensionServiceTestBase into its own header/cc file This is the first step in refactoring the (overly-gigantic) extension_service_unittest.cc BUG=381251 TBR=atwilson@chromium.org (c/b/background/) TBR=bauerb@chromium.org (c/b/managed_mode/) TBR=battre@chromium.org (c/b/profile_resetter/) TBR=pkotwicz@chromium.org (c/b/themes) TBR=koz@chromium.org (c/b/ui/app_list) All TBRs are for simple mechanical changes (primarily namespace move). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276587

Patch Set 1 : #

Total comments: 5

Patch Set 2 : Nit #

Patch Set 3 : Fix merge conflict #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1724 lines, -1580 lines) Patch
M chrome/browser/background/background_application_list_model_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/bookmark_app_helper_unittest.cc View 6 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/extensions/extension_context_menu_model_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_error_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_garbage_collector_chromeos_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_garbage_collector_unittest.cc View 8 chunks +17 lines, -16 lines 0 comments Download
A chrome/browser/extensions/extension_service_test_base.h View 1 chunk +145 lines, -0 lines 0 comments Download
A chrome/browser/extensions/extension_service_test_base.cc View 1 1 chunk +228 lines, -0 lines 0 comments Download
D chrome/browser/extensions/extension_service_unittest.h View 1 chunk +0 lines, -111 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 2 255 chunks +1268 lines, -1404 lines 0 comments Download
M chrome/browser/extensions/external_provider_impl_chromeos_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/external_provider_impl_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/permissions_updater_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/shared_module_service_unittest.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/extensions/user_script_listener_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/managed_mode/managed_user_service_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/profile_resetter/automatic_profile_resetter_delegate_unittest.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/profile_resetter/profile_resetter_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/themes/theme_service_unittest.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_test_util.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_test_util.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/app_list/extension_app_model_builder_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/app_list/search/app_search_provider_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M extensions/DEPS View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/browser/lazy_background_task_queue_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
Devlin
https://codereview.chromium.org/318863008/diff/80001/chrome/browser/extensions/extension_service_unittest.cc File chrome/browser/extensions/extension_service_unittest.cc (right): https://codereview.chromium.org/318863008/diff/80001/chrome/browser/extensions/extension_service_unittest.cc#newcode1111 chrome/browser/extensions/extension_service_unittest.cc:1111: size_t expected_extensions_count_; STOP! Every change past this line is ...
6 years, 6 months ago (2014-06-10 21:46:06 UTC) #1
Yoyo Zhou
LGTM, nice! https://codereview.chromium.org/318863008/diff/80001/chrome/browser/extensions/extension_service_test_base.cc File chrome/browser/extensions/extension_service_test_base.cc (right): https://codereview.chromium.org/318863008/diff/80001/chrome/browser/extensions/extension_service_test_base.cc#newcode189 chrome/browser/extensions/extension_service_test_base.cc:189: } nit: newline https://codereview.chromium.org/318863008/diff/80001/extensions/DEPS File extensions/DEPS (right): ...
6 years, 6 months ago (2014-06-11 02:13:50 UTC) #2
Devlin
https://codereview.chromium.org/318863008/diff/80001/chrome/browser/extensions/extension_service_test_base.cc File chrome/browser/extensions/extension_service_test_base.cc (right): https://codereview.chromium.org/318863008/diff/80001/chrome/browser/extensions/extension_service_test_base.cc#newcode189 chrome/browser/extensions/extension_service_test_base.cc:189: } On 2014/06/11 02:13:50, Yoyo Zhou wrote: > nit: ...
6 years, 6 months ago (2014-06-11 15:44:17 UTC) #3
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 6 months ago (2014-06-11 15:44:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/318863008/100001
6 years, 6 months ago (2014-06-11 15:46:40 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 21:07:31 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 21:25:05 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/builds/19606)
6 years, 6 months ago (2014-06-11 21:25:06 UTC) #8
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 6 months ago (2014-06-11 21:49:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/318863008/120001
6 years, 6 months ago (2014-06-11 21:52:37 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_compile_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 23:14:30 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 23:15:59 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/15764) win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/18896)
6 years, 6 months ago (2014-06-11 23:16:00 UTC) #13
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 6 months ago (2014-06-11 23:18:21 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/318863008/120001
6 years, 6 months ago (2014-06-11 23:19:41 UTC) #15
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_compile_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-12 00:40:02 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-12 00:41:36 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/18956)
6 years, 6 months ago (2014-06-12 00:41:37 UTC) #18
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 6 months ago (2014-06-12 01:10:40 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/318863008/120001
6 years, 6 months ago (2014-06-12 01:11:56 UTC) #20
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 08:38:22 UTC) #21
Message was sent while issue was closed. 
Change committed as 276587

Powered by Google App Engine
This is Rietveld 408576698