Chromium Code Reviews Chromium Code Reviews
Issue 318863008:
Move ExtensionServiceTestBase into it's own header/cc file (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW |
|---|---|
| 1 include_rules = [ | 1 include_rules = [ |
| 2 "+components/url_matcher", | 2 "+components/url_matcher", |
| 3 "+content/public/common", | 3 "+content/public/common", |
| 4 "+crypto", | 4 "+crypto", |
| 5 "+grit/extensions_renderer_resources.h", | 5 "+grit/extensions_renderer_resources.h", |
| 6 "+grit/extensions_resources.h", | 6 "+grit/extensions_resources.h", |
| 7 "+testing", | 7 "+testing", |
| 8 "+ui", | 8 "+ui", |
| 9 | 9 |
| 10 # Temporarily allowed includes as part of the app shell/extensions refactor. | 10 # Temporarily allowed includes as part of the app shell/extensions refactor. |
| (...skipping 10 matching lines...) Expand all Loading... | |
| 21 "+content/public/test", | 21 "+content/public/test", |
| 22 | 22 |
| 23 # Temporarily allowed testing includes. See above. | 23 # Temporarily allowed testing includes. See above. |
| 24 # TODO(jamescook): Remove these. http://crbug.com/162530 | 24 # TODO(jamescook): Remove these. http://crbug.com/162530 |
| 25 "+chrome/browser/apps/app_browsertest_util.h", | 25 "+chrome/browser/apps/app_browsertest_util.h", |
| 26 "+chrome/browser/extensions/api/management/management_api.h", | 26 "+chrome/browser/extensions/api/management/management_api.h", |
| 27 "+chrome/browser/extensions/api/permissions/permissions_api.h", | 27 "+chrome/browser/extensions/api/permissions/permissions_api.h", |
| 28 "+chrome/browser/extensions/extension_api_unittest.h", | 28 "+chrome/browser/extensions/extension_api_unittest.h", |
| 29 "+chrome/browser/extensions/extension_apitest.h", | 29 "+chrome/browser/extensions/extension_apitest.h", |
| 30 "+chrome/browser/extensions/extension_function_test_utils.h", | 30 "+chrome/browser/extensions/extension_function_test_utils.h", |
| 31 "+chrome/browser/extensions/extension_service_unittest.h", | 31 "+chrome/browser/extensions/extension_service.h", |
|
Devlin
2014/06/10 21:46:06
This isn't new - it just removes the transitive de
Yoyo Zhou
2014/06/11 02:13:50
Yeah, I've noticed a few more of these.
| |
| 32 "+chrome/browser/extensions/extension_service_test_base.h", | |
| 32 "+chrome/browser/extensions/test_extension_dir.h", | 33 "+chrome/browser/extensions/test_extension_dir.h", |
| 33 "+chrome/browser/extensions/test_extension_system.h", | 34 "+chrome/browser/extensions/test_extension_system.h", |
| 34 "+chrome/browser/ui/browser.h", | 35 "+chrome/browser/ui/browser.h", |
| 35 "+chrome/common/chrome_paths.h", | 36 "+chrome/common/chrome_paths.h", |
| 36 "+chrome/common/extensions/features/feature_channel.h", | 37 "+chrome/common/extensions/features/feature_channel.h", |
| 37 "+chrome/common/extensions/manifest_tests/extension_manifest_test.h", | 38 "+chrome/common/extensions/manifest_tests/extension_manifest_test.h", |
| 38 "+chrome/test/base/testing_profile.h", | 39 "+chrome/test/base/testing_profile.h", |
| 39 "+chrome/test/base/ui_test_utils.h", | 40 "+chrome/test/base/ui_test_utils.h", |
| 40 ], | 41 ], |
| 41 "(simple|complex)_feature_unittest\.cc|base_feature_provider_unittest\.cc": [ | 42 "(simple|complex)_feature_unittest\.cc|base_feature_provider_unittest\.cc": [ |
| 42 "+chrome/common/extensions/features/chrome_channel_feature_filter.h", | 43 "+chrome/common/extensions/features/chrome_channel_feature_filter.h", |
| 43 ], | 44 ], |
| 44 "permissions_data_unittest\.cc": [ | 45 "permissions_data_unittest\.cc": [ |
| 45 "+chrome/common/chrome_version_info.h", | 46 "+chrome/common/chrome_version_info.h", |
| 46 "+chrome/common/extensions/extension_test_util.h", | 47 "+chrome/common/extensions/extension_test_util.h", |
| 47 "+chrome/common/extensions/features/feature_channel.h", | 48 "+chrome/common/extensions/features/feature_channel.h", |
| 48 ], | 49 ], |
| 49 } | 50 } |
| OLD | NEW |
