Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Issue 318823002: [NaCl SDK] Don't set minimum_chrome_version for most examples. (Closed)

Created:
6 years, 6 months ago by binji
Modified:
6 years, 6 months ago
Reviewers:
noelallen1, Sam Clegg
CC:
chromium-reviews, binji+watch_chromium.org
Visibility:
Public.

Description

[NaCl SDK] Don't set minimum_chrome_version for most examples. Most examples work with Chrome stable (currently M35), so don't require apps to use a newer version of Chrome. No examples need a later version of Chrome, but a few use features that just made it to stable. In this case, we allow the minimum version to be specified in example.dsc. BUG=none R=sbc@chromium.org, noelallen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275454

Patch Set 1 #

Total comments: 4

Patch Set 2 : feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M native_client_sdk/src/build_tools/generate_make.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M native_client_sdk/src/build_tools/parse_dsc.py View 1 chunk +1 line, -0 lines 0 comments Download
M native_client_sdk/src/examples/api/media_stream_audio/example.dsc View 1 chunk +2 lines, -1 line 0 comments Download
M native_client_sdk/src/examples/api/media_stream_video/example.dsc View 1 chunk +2 lines, -1 line 0 comments Download
M native_client_sdk/src/resources/manifest.json.template View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
binji
6 years, 6 months ago (2014-06-04 21:31:28 UTC) #1
binji
ping
6 years, 6 months ago (2014-06-05 18:25:46 UTC) #2
Sam Clegg
https://codereview.chromium.org/318823002/diff/1/native_client_sdk/src/build_tools/generate_make.py File native_client_sdk/src/build_tools/generate_make.py (right): https://codereview.chromium.org/318823002/diff/1/native_client_sdk/src/build_tools/generate_make.py#newcode165 native_client_sdk/src/build_tools/generate_make.py:165: 'version': version, Why have you created this 'version' variable? ...
6 years, 6 months ago (2014-06-05 19:33:13 UTC) #3
binji
https://codereview.chromium.org/318823002/diff/1/native_client_sdk/src/build_tools/generate_make.py File native_client_sdk/src/build_tools/generate_make.py (right): https://codereview.chromium.org/318823002/diff/1/native_client_sdk/src/build_tools/generate_make.py#newcode165 native_client_sdk/src/build_tools/generate_make.py:165: 'version': version, On 2014/06/05 19:33:12, Sam Clegg wrote: > ...
6 years, 6 months ago (2014-06-05 20:22:39 UTC) #4
Sam Clegg
On 2014/06/05 20:22:39, binji wrote: > https://codereview.chromium.org/318823002/diff/1/native_client_sdk/src/build_tools/generate_make.py > File native_client_sdk/src/build_tools/generate_make.py (right): > > https://codereview.chromium.org/318823002/diff/1/native_client_sdk/src/build_tools/generate_make.py#newcode165 > ...
6 years, 6 months ago (2014-06-05 21:09:26 UTC) #5
Sam Clegg
lgtm
6 years, 6 months ago (2014-06-05 21:09:29 UTC) #6
binji
6 years, 6 months ago (2014-06-06 16:12:34 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r275454 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698