native_client_sdk/src/build_tools/generate_make.py - Issue 318823002: [NaCl SDK] Don't set minimum_chrome_version for most examples.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: native_client_sdk/src/build_tools/generate_make.py

Issue 318823002: [NaCl SDK] Don't set minimum_chrome_version for most examples. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: feedback Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: native_client_sdk/src/build_tools/generate_make.py

diff --git a/native_client_sdk/src/build_tools/generate_make.py b/native_client_sdk/src/build_tools/generate_make.py

index 45eb9336f89f08c442e3ae5eae4ceedeb76d6758..febbd51fc7ff45b17b834faac8abd4e63b5f5035 100644

--- a/native_client_sdk/src/build_tools/generate_make.py

+++ b/native_client_sdk/src/build_tools/generate_make.py

@@ -160,7 +160,8 @@ def GenerateManifest(srcroot, dstroot, desc):

'channel': None,

'permissions': pretty_permissions,

'multi_platform': desc.get('MULTI_PLATFORM', False),

- 'version': build_version.ChromeVersionNoTrunk()

+ 'version': build_version.ChromeVersionNoTrunk(),

+ 'min_chrome_version': desc.get('MIN_CHROME_VERSION')

}

RunTemplateFileIfChanged(srcpath, dstpath, replace)

« no previous file with comments | « no previous file | native_client_sdk/src/build_tools/parse_dsc.py » ('j') | no next file with comments »