Do not exclude pdf from DEPS check.

Do not exclude pdf from DEPS check.

Otherwise the DEPS file under pdf/ directory has no effect.

As a result of enabling it, some entries had to be added.

BUG=None
TEST=./tools/checkdeps/checkdeps.py - SUCCESS
R=thestig@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275148

[Lei Zhang, 2014-06-04 22:34:33]

lgtm with suggestion below

https://codereview.chromium.org/318763005/diff/1/pdf/DEPS
File pdf/DEPS (right):

https://codereview.chromium.org/318763005/diff/1/pdf/DEPS#newcode8
pdf/DEPS:8: "+ui/events",
Just ui/events/keycodes/keyboard_codes.h ?

[Lei Zhang, 2014-06-04 22:35:03]

And strangely I'm not in pdf/OWNERS.

[jam, 2014-06-04 22:38:40]

On 2014/06/04 22:35:03, Lei Zhang wrote:
> And strangely I'm not in pdf/OWNERS.

you are:
ttp://src.chromium.org/viewvc/chrome/trunk/src/pdf/OWNERS?revision=271531 ?

[tfarina, 2014-06-04 22:45:28]

https://codereview.chromium.org/318763005/diff/1/pdf/DEPS
File pdf/DEPS (right):

https://codereview.chromium.org/318763005/diff/1/pdf/DEPS#newcode8
pdf/DEPS:8: "+ui/events",
On 2014/06/04 22:34:33, Lei Zhang wrote:
> Just ui/events/keycodes/keyboard_codes.h ?
Do you want to restrict it to only that file? I'm fine to change if you want, I
just took the decision of going with ui/events based on the assumption that it
is fine to include everything from ui/ and if someone comes here and add another
include from ui/events it does not have to update the DEPS again.

[Lei Zhang, 2014-06-04 22:48:38]

On 2014/06/04 22:38:40, jam wrote:
> On 2014/06/04 22:35:03, Lei Zhang wrote:
> > And strangely I'm not in pdf/OWNERS.
> 
> you are:
> ttp://src.chromium.org/viewvc/chrome/trunk/src/pdf/OWNERS?revision=271531 ?

The lack of a newline on the very last line of the file confused me, since my
shell prompt also starts with thestig@ ...

[Lei Zhang, 2014-06-04 22:51:43]

On 2014/06/04 22:45:28, tfarina wrote:
> https://codereview.chromium.org/318763005/diff/1/pdf/DEPS
> File pdf/DEPS (right):
> 
> https://codereview.chromium.org/318763005/diff/1/pdf/DEPS#newcode8
> pdf/DEPS:8: "+ui/events",
> On 2014/06/04 22:34:33, Lei Zhang wrote:
> > Just ui/events/keycodes/keyboard_codes.h ?
> Do you want to restrict it to only that file? I'm fine to change if you want,
I
> just took the decision of going with ui/events based on the assumption that it
> is fine to include everything from ui/ and if someone comes here and add
another
> include from ui/events it does not have to update the DEPS again.

Yes, we don't use anything else in ui/events, so why allow it? For instance, I
don't think we'd ever want ui/events/ozone in pdf. If/when we do, we should make
a conscious decision to do so.

[tfarina, 2014-06-05 02:08:13]

https://codereview.chromium.org/318763005/diff/1/pdf/DEPS
File pdf/DEPS (right):

https://codereview.chromium.org/318763005/diff/1/pdf/DEPS#newcode8
pdf/DEPS:8: "+ui/events",
On 2014/06/04 22:34:33, Lei Zhang wrote:
> Just ui/events/keycodes/keyboard_codes.h ?

Done.

[Lei Zhang, 2014-06-05 02:22:47]

lgtm

[tfarina, 2014-06-05 02:47:39]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2014-06-05 02:48:46]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tfarina@chromium.org/318763005/20001

[commit-bot: I haz the power, 2014-06-05 06:40:48]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)

[commit-bot: I haz the power, 2014-06-05 06:44:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-05 06:44:31]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[Lei Zhang, 2014-06-05 06:47:49]

+sadrul for UI. We've been using the keycodes file in pdf before it was open
sourced.

[sadrul, 2014-06-05 16:05:06]

lgtm

[tfarina, 2014-06-05 16:06:26]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2014-06-05 16:07:50]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tfarina@chromium.org/318763005/20001

[commit-bot: I haz the power, 2014-06-05 16:24:57]

Change committed as 275148