pdf/DEPS - Issue 318763005: Do not exclude pdf from DEPS check.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: pdf/DEPS

Issue 318763005: Do not exclude pdf from DEPS check. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 include_rules = [	1 include_rules = [

	2 "!chrome/browser/chrome_page_zoom_constants.h",

	3 "!chrome/common/content_restriction.h",

	4 "!content/public/common/page_zoom.h",

2 "+net",	5 "+net",

3 "+ppapi",	6 "+ppapi",

4 "+third_party/pdfium/fpdfsdk/include",	7 "+third_party/pdfium/fpdfsdk/include",

	8 "+ui/events",
	Lei Zhang 2014/06/04 22:34:33 Just ui/events/keycodes/keyboard_codes.h ? Just ui/events/keycodes/keyboard_codes.h ? tfarina 2014/06/04 22:45:28 Do you want to restrict it to only that file? I'm Show quoted text On 2014/06/04 22:34:33, Lei Zhang wrote: > Just ui/events/keycodes/keyboard_codes.h ? Do you want to restrict it to only that file? I'm fine to change if you want, I just took the decision of going with ui/events based on the assumption that it is fine to include everything from ui/ and if someone comes here and add another include from ui/events it does not have to update the DEPS again. tfarina 2014/06/05 02:08:13 Done. Show quoted text On 2014/06/04 22:34:33, Lei Zhang wrote: > Just ui/events/keycodes/keyboard_codes.h ? Done.
5 ]	9 ]

OLD	NEW

« no previous file with comments | « DEPS ('k') | no next file » | no next file with comments »