Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 318763003: PPAPI: Add C++ wrapper for MessageHandler stuff. (Closed)

Created:
6 years, 6 months ago by dmichael (off chromium)
Modified:
6 years, 3 months ago
Reviewers:
bbudge, binji
CC:
chromium-reviews, yusukes+watch_chromium.org, tzik, binji+watch_chromium.org, raymes+watch_chromium.org, teravest+watch_chromium.org, nfullagar1, piman+watch_chromium.org, noelallen1, Sam Clegg, ihf+watch_chromium.org
Visibility:
Public.

Description

PPAPI: Add C++ wrapper for MessageHandler stuff. BUG=367896 Committed: https://crrev.com/b8737917043275c52ae682cddc6604c495d2e73f Cr-Commit-Position: refs/heads/master@{#295495}

Patch Set 1 #

Patch Set 2 : Update, make test use C++, add comments #

Total comments: 5

Patch Set 3 : Review fixes, hopefully SDK fix #

Patch Set 4 : move messag_handler.h to HEADERS section of library.dsc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+218 lines, -73 lines) Patch
M native_client_sdk/src/libraries/ppapi_cpp/library.dsc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/api/ppp_message_handler.idl View 1 2 chunks +9 lines, -4 lines 0 comments Download
M ppapi/c/ppp_message_handler.h View 1 3 chunks +10 lines, -5 lines 0 comments Download
M ppapi/cpp/instance.h View 1 2 2 chunks +51 lines, -0 lines 0 comments Download
M ppapi/cpp/instance.cc View 1 3 chunks +58 lines, -3 lines 0 comments Download
A ppapi/cpp/message_handler.h View 1 2 1 chunk +57 lines, -0 lines 0 comments Download
M ppapi/ppapi_sources.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/tests/test_message_handler.cc View 1 5 chunks +31 lines, -61 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
bbudge
LGTM w / comments https://codereview.chromium.org/318763003/diff/20001/ppapi/cpp/instance.h File ppapi/cpp/instance.h (right): https://codereview.chromium.org/318763003/diff/20001/ppapi/cpp/instance.h#newcode505 ppapi/cpp/instance.h:505: /// postMessageAndAwaitResponse will be dispatched ...
6 years, 3 months ago (2014-09-18 12:41:17 UTC) #2
dmichael (off chromium)
+binji for library.dsc
6 years, 3 months ago (2014-09-18 15:50:10 UTC) #4
binji
native_client_sdk lgtm
6 years, 3 months ago (2014-09-18 16:33:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/318763003/60001
6 years, 3 months ago (2014-09-18 16:36:35 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 44f524b61a1b7cdd0c63ab9a5c90656b7475478d
6 years, 3 months ago (2014-09-18 18:00:41 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 18:01:16 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/b8737917043275c52ae682cddc6604c495d2e73f
Cr-Commit-Position: refs/heads/master@{#295495}

Powered by Google App Engine
This is Rietveld 408576698