Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 318743003: Revert 273547 "Reset scoped_ptr to make plugin crash before ente..." (Closed)

Created:
6 years, 6 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 273547 "Reset scoped_ptr to make plugin crash before ente..." > Reset scoped_ptr to make plugin crash before entering engine_->HandleDocumentLoad, if called for deleted "Instance". > Suspecting method call for deleted instance. > > Example to explain why reset() makes difference: > > scoped_ptr<int>* pt = NULL; > { > scoped_ptr<int> t(new int); > pt = &t; > } > DCHECK(!(*pt)); // Fail > { > scoped_ptr<int> t(new int); > pt = &t; > t.reset(); > } > DCHECK(!(*pt)); // OK > > BUG=372095, 372548 > > Review URL: https://codereview.chromium.org/300403002 TBR=vitalybuka@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274854

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M trunk/src/pdf/instance.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Vitaly Buka (NO REVIEWS)
6 years, 6 months ago (2014-06-04 17:26:22 UTC) #1
Vitaly Buka (NO REVIEWS)
6 years, 6 months ago (2014-06-04 17:26:55 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r274854.

Powered by Google App Engine
This is Rietveld 408576698