Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 300403002: Reset scoped_ptr to make plugin crash on higher level. (Closed)

Created:
6 years, 6 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 6 months ago
Reviewers:
gene, gene1
CC:
chromium-reviews
Visibility:
Public.

Description

Reset scoped_ptr to make plugin crash before entering engine_->HandleDocumentLoad, if called for deleted "Instance". Suspecting method call for deleted instance. Example to explain why reset() makes difference: scoped_ptr<int>* pt = NULL; { scoped_ptr<int> t(new int); pt = &t; } DCHECK(!(*pt)); // Fail { scoped_ptr<int> t(new int); pt = &t; t.reset(); } DCHECK(!(*pt)); // OK BUG=372095, 372548 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273547

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M pdf/instance.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Vitaly Buka (NO REVIEWS)
6 years, 6 months ago (2014-05-28 23:34:56 UTC) #1
gene1
lgtm
6 years, 6 months ago (2014-05-28 23:40:56 UTC) #2
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 6 months ago (2014-05-28 23:41:45 UTC) #3
Vitaly Buka (NO REVIEWS)
The CQ bit was unchecked by vitalybuka@chromium.org
6 years, 6 months ago (2014-05-28 23:42:05 UTC) #4
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 6 months ago (2014-05-28 23:43:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/300403002/1
6 years, 6 months ago (2014-05-28 23:44:46 UTC) #6
gene
lgtm
6 years, 6 months ago (2014-05-29 01:57:42 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 6 months ago (2014-05-29 04:08:00 UTC) #8
Vitaly Buka (NO REVIEWS)
The CQ bit was unchecked by vitalybuka@chromium.org
6 years, 6 months ago (2014-05-29 05:23:58 UTC) #9
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 6 months ago (2014-05-29 05:25:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/300403002/1
6 years, 6 months ago (2014-05-29 05:25:47 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-05-29 19:38:05 UTC) #12
Message was sent while issue was closed.
Change committed as 273547

Powered by Google App Engine
This is Rietveld 408576698