|
DONOTLAND: Start of PK11 password dialog for Linux/NSS
A number of things make this rather messy:
- NSS's dialog is blocking
- WebKit doesn't tell us which tab requested a keygen
So, in the worst case, we need something which blocks on the UI thread with a
dialog. This must be moved to a worker thread. For other things, we can drive
the authentication ourselves with PK11_CheckUserPassword with an asynchronously
dialog.
Another issue is that the hang monitor needs to be stopped as WebKit currently blocks on the key generation. This is a nuisance because WebKit doesn't even tell us what page (WebView?) made the request, so we don't get a render view id and routed IPC. I don't think this can be solved without WebKit-side changes.
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+437 lines, -38 lines) |
Patch |
|
M |
base/nss_util.cc
|
View
|
1
2
|
2 chunks |
+13 lines, -0 lines |
0 comments
|
Download
|
|
M |
base/nss_util_internal.h
|
View
|
|
1 chunk |
+18 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/app/generated_resources.grd
|
View
|
2
|
1 chunk |
+20 lines, -0 lines |
0 comments
|
Download
|
|
A |
chrome/browser/gtk/pk11_password_dialog.h
|
View
|
|
1 chunk |
+47 lines, -0 lines |
0 comments
|
Download
|
|
A |
chrome/browser/gtk/pk11_password_dialog.cc
|
View
|
1
|
1 chunk |
+231 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/browser/renderer_host/resource_message_filter.cc
|
View
|
1
2
|
4 chunks |
+23 lines, -0 lines |
0 comments
|
Download
|
|
M |
chrome/chrome_browser.gypi
|
View
|
1
2
|
2 chunks |
+4 lines, -0 lines |
0 comments
|
Download
|
|
M |
net/base/keygen_handler.h
|
View
|
|
3 chunks |
+22 lines, -12 lines |
0 comments
|
Download
|
|
A |
net/base/keygen_handler.cc
|
View
|
|
1 chunk |
+28 lines, -0 lines |
0 comments
|
Download
|
|
M |
net/base/keygen_handler_nss.cc
|
View
|
|
2 chunks |
+26 lines, -1 line |
0 comments
|
Download
|
|
M |
net/net.gyp
|
View
|
1
2
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
net/third_party/mozilla_security_manager/nsKeygenHandler.h
|
View
|
|
2 chunks |
+3 lines, -0 lines |
0 comments
|
Download
|
|
M |
net/third_party/mozilla_security_manager/nsKeygenHandler.cpp
|
View
|
|
5 chunks |
+1 line, -25 lines |
0 comments
|
Download
|
|