Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2445)

Unified Diff: chrome/browser/ssl/captive_portal_blocking_page.h

Issue 318213002: Add custom interstitial for captive portals. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove unnecessary change Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/captive_portal_blocking_page.h
diff --git a/chrome/browser/ssl/captive_portal_blocking_page.h b/chrome/browser/ssl/captive_portal_blocking_page.h
new file mode 100644
index 0000000000000000000000000000000000000000..5fce504c936b98ee1bcdbe18f49c1619ad8c38f4
--- /dev/null
+++ b/chrome/browser/ssl/captive_portal_blocking_page.h
@@ -0,0 +1,43 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_SSL_CAPTIVE_PORTAL_BLOCKING_PAGE_H_
+#define CHROME_BROWSER_SSL_CAPTIVE_PORTAL_BLOCKING_PAGE_H_
+
+#include <string>
+
+#include "chrome/browser/interstitials/security_interstitial_page.h"
+#include "url/gurl.h"
Ryan Sleevi 2014/10/29 23:17:32 You can forward declare GURL here.
meacer 2014/11/06 21:21:56 Done.
+
+// This class is responsible for showing/hiding the interstitial page that is
+// shown when a captive portal and an SSL error is detected.
+// It deletes itself when the interstitial page is closed.
+//
+// This class should only be used on the UI thread because its implementation
+// uses captive_portal::CaptivePortalService which can only be accessed on the
Ryan Sleevi 2014/10/29 23:17:32 "CaptivePortalService which " -> "CaptivePortalSer
meacer 2014/11/06 21:21:56 Done.
+// UI thread.
+class CaptivePortalBlockingPage : public SecurityInterstitialPage {
+ public:
+ CaptivePortalBlockingPage(content::WebContents* web_contents,
+ const GURL& request_url);
+ virtual ~CaptivePortalBlockingPage();
mmenke 2014/10/30 19:28:02 -virtual, +override
meacer 2014/11/06 21:21:56 Done.
+
+ // SecurityInterstitialPage method:
+ virtual SecurityInterstitialPage::Type GetTypeForTesting() const override;
+
+ protected:
+ // SecurityInterstitialPage implementation:
+ virtual void PopulateLoadTimeData(
+ base::DictionaryValue* load_time_data) override;
+ virtual bool ShouldCreateNewNavigation() const override;
+
+ // InterstitialPageDelegate implementation.
+ virtual void CommandReceived(const std::string& command) override;
mmenke 2014/10/30 19:28:02 -virtual(x4)
meacer 2014/11/06 21:21:56 Done.
+
+ private:
+
Ryan Sleevi 2014/10/29 23:17:32 nit: no newline.
meacer 2014/11/06 21:21:56 Done.
+ DISALLOW_COPY_AND_ASSIGN(CaptivePortalBlockingPage);
mmenke 2014/10/30 19:28:02 include base/macros.h for DISALLOW_COPY_AND_ASSIGN
meacer 2014/11/06 21:21:55 Done.
+};
+
+#endif // CHROME_BROWSER_SSL_CAPTIVE_PORTAL_BLOCKING_PAGE_H_

Powered by Google App Engine
This is Rietveld 408576698