Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Side by Side Diff: chrome/browser/ssl/captive_portal_blocking_page.h

Issue 318213002: Add custom interstitial for captive portals. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove unnecessary change Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CHROME_BROWSER_SSL_CAPTIVE_PORTAL_BLOCKING_PAGE_H_
6 #define CHROME_BROWSER_SSL_CAPTIVE_PORTAL_BLOCKING_PAGE_H_
7
8 #include <string>
9
10 #include "chrome/browser/interstitials/security_interstitial_page.h"
11 #include "url/gurl.h"
Ryan Sleevi 2014/10/29 23:17:32 You can forward declare GURL here.
meacer 2014/11/06 21:21:56 Done.
12
13 // This class is responsible for showing/hiding the interstitial page that is
14 // shown when a captive portal and an SSL error is detected.
15 // It deletes itself when the interstitial page is closed.
16 //
17 // This class should only be used on the UI thread because its implementation
18 // uses captive_portal::CaptivePortalService which can only be accessed on the
Ryan Sleevi 2014/10/29 23:17:32 "CaptivePortalService which " -> "CaptivePortalSer
meacer 2014/11/06 21:21:56 Done.
19 // UI thread.
20 class CaptivePortalBlockingPage : public SecurityInterstitialPage {
21 public:
22 CaptivePortalBlockingPage(content::WebContents* web_contents,
23 const GURL& request_url);
24 virtual ~CaptivePortalBlockingPage();
mmenke 2014/10/30 19:28:02 -virtual, +override
meacer 2014/11/06 21:21:56 Done.
25
26 // SecurityInterstitialPage method:
27 virtual SecurityInterstitialPage::Type GetTypeForTesting() const override;
28
29 protected:
30 // SecurityInterstitialPage implementation:
31 virtual void PopulateLoadTimeData(
32 base::DictionaryValue* load_time_data) override;
33 virtual bool ShouldCreateNewNavigation() const override;
34
35 // InterstitialPageDelegate implementation.
36 virtual void CommandReceived(const std::string& command) override;
mmenke 2014/10/30 19:28:02 -virtual(x4)
meacer 2014/11/06 21:21:56 Done.
37
38 private:
39
Ryan Sleevi 2014/10/29 23:17:32 nit: no newline.
meacer 2014/11/06 21:21:56 Done.
40 DISALLOW_COPY_AND_ASSIGN(CaptivePortalBlockingPage);
mmenke 2014/10/30 19:28:02 include base/macros.h for DISALLOW_COPY_AND_ASSIGN
meacer 2014/11/06 21:21:55 Done.
41 };
42
43 #endif // CHROME_BROWSER_SSL_CAPTIVE_PORTAL_BLOCKING_PAGE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698